410124 - Support plugin blocklist notification

Status: RESOLVED FIXED

(SeaMonkey :: UI Design, defect)

Description

[[e-mail]]

SeaMonkey version of bug 388445.

Comment 1

[Teune van Steeg]

Attachment: patch

Comment 2

[[e-mail]]

Comment on attachment 295764 [details] [diff] [review]
patch

>+              var whereToOpen = self._prefs.getIntPref("browser.link.open_external");
I can't decide whether to go with this code (which I assume is roughly equivalent to openAsExternal in contentAreaUtils.js) or whether to use a version of toolkit's openURL in its utilityOverlay.js but I'll stick with this version unless jag you have a strong preference for cloning openURL.

>+blockedpluginsMessage.infoButton.label=Details…
We're not ellipsis-ready yet. Please stick to three full stops. (Annoyingly in my default bold font an ellipsis looks like an underscore...)

Comment 3

[Teune van Steeg]

Attachment: patch (v1.1)

Updated patch: use ... instead of the ellipsis.

Comment 4

[jag (Peter Annema)]

Comment on attachment 298167 [details] [diff] [review]
patch (v1.1)

sr=jag

Comment 5

[Reed Loden [:reed]]

Checking in suite/common/bindings/notification.xml;
/cvsroot/mozilla/suite/common/bindings/notification.xml,v  <--  notification.xml
new revision: 1.5; previous revision: 1.4
done
Checking in suite/locales/en-US/chrome/common/notification.properties;
/cvsroot/mozilla/suite/locales/en-US/chrome/common/notification.properties,v  <--  notification.properties
new revision: 1.4; previous revision: 1.3
done