410154 - It's not possible to show the Search Bar in unifinder anymore

Status: VERIFIED WORKSFORME

(Calendar :: Sunbird Only, defect)

Description

[Stefan Sitter [:ssitter]]

Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.8.1.12pre) Gecko/20071228 Calendar/0.8pre

It's not possible to show the Search Bar in unifinder anymore

Steps to Reproduce:
1. Install any Sunbird build of 0.2 / 0.3 / 0.5 / 0.7
2. Hide the Search Bar via menu entry View -> Search Bar
3. Update to Sunbird 0.8pre (20071228) or newer
4. Try to show the Search Bar

Actual Results:
The menu entry is gone. There is now only a menu entry Edit -> Find Events that will show/hide the Unifinder. It's not possible to show the Search Bar anymore.

Expected Results:
It should be possible to show the Search Bar if required. After upgrade from any previous build the known functionality should be available.

Regression Range:
Works in Sunbird 0.8pre (2007-12-27-06)
Fails in Sunbird 0.8pre (2007-12-28-06)

Comment 1

[Simon Paquet [:sipaq]]

IMO this bug is WONTFIX. 

We do not need to double existing functionality in Sunbird. In addition the new disable-unifinder-feature provides all the features from the old search bar in Sunbird with the additional features provided by the unifinder.

Christian, you should comment on this as well.

Comment 2

[Stefan Sitter [:ssitter]]

Simon, it's not the same functionality, see the STR. Showing the Search Bar is different from showing the Unifinder. The new introduced command toggles only the Unifinder but not the Search Bar. Users of Sunbird 0.2 / 0.3 / 0.5 / 0.7 have no way to show the Search Bar again after upgrade to 0.8pre -> major loss of functionality.

Comment 3

[Simon Paquet [:sipaq]]

Stefan, the unifinder toggled by the "Find events" button or menuitem contains the Search Bar. Therefore I see no loss of functionality.

Comment 4

[Stefan Sitter [:ssitter]]

Maybe my description in Comment #0 was unclear: The Search Bar is not visible in the Unifinder if it was hidden in a previous build via the existing menu entry "View->Search Bar". The now existing menu entry "Edit->Find Events" just toggles the Unifinder but doesn't bring back the Search Bar. The only way to get the Search Bar back is by downgrading to the latest working build, show it via the corresponding menu entry and upgrade again.

1st issue: Search Bar is not available if it was hidden before the upgrade. Users can't search events -> loss of functionality.

2nd issue: Search Bar can't be hidden on the fly anymore. This breaks for example my usage of Sunbird as described in Bug 402177 Comment #20 -> loss of functionality.

The 2nd might be discussible but the 1st must be fixed.

Comment 5

[Simon Paquet [:sipaq]]

Ok, I think I understand now. 

The reason for this is, that we currently just toggle the overarching vbox (bottom-events-box) which contains the search-bar hbox (unifinder-searchBox) and the event list in a tree (unifinder-search-results-tree).

If you had hidden the search bar in a previous version, this is most likely stored in localstore.rdf and toggling the vbox does not bring it back. I managed to fix this locally by replacing the following line in calendar-common-sets.xul

<command id="calendar_show_unifinder_command" oncommand="goToggleToolbar('bottom-events-box', 'calendar_show_unifinder_command'); goToggleToolbar('calendar-view-splitter');"/>

with this:

<command id="calendar_show_unifinder_command"              oncommand="goToggleToolbar('unifinder-searchBox', 'calendar_show_unifinder_command');                         goToggleToolbar('unifinder-search-results-tree');                         goToggleToolbar('calendar-view-splitter');"/>

Stefan, can you please try if this fixes it for you as well. Then I can prepare a patch.

Comment 6

[Simon Paquet [:sipaq]]

Attachment: Patch v1

Comment 7

[Simon Paquet [:sipaq]]

Not important enough for blocking, but definitely wanted.

Comment 8

[Michael Büttner (no reviews TFN)]

Comment on attachment 298163 [details]
Patch v1

>+    goToggleToolbar('unifinder-searchBox', 'calendar_show_unifinder_command');
>+    goToggleToolbar('unifinder-search-results-tree');
As far as I know the unifinder searchbox has been collapsed instead of made invisible. Furthermore, I don't see a reason for hiding the nested elements of the enclosing container, i.e. hiding child elements of bottom-events-box.

I think it's better to change the unifinder-searchbox element. It currently persists the collapsed attribute which is what we want to avoid:
      <hbox id="unifinder-searchBox" persist="collapsed">

This could be changed to reflect the new behavior:
<hbox id="unifinder-searchBox" collapsed="false">

Last but not least, the patch probably won't have the desired effect. Assume the searchbox has been made invisible (by some previous calendar version), toggleUnifinder() will hide the unifinder and make the searchbox visible, but it won't show since the container has been made invisible. Then, showing the unifinder will hide again the searchbox. I didn't try this out, but showing the searchbox unconditionally is clearly the superior approach.

Comment 9

[Stefan Sitter [:ssitter]]

Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8.1.12pre) Gecko/2008012209 Calendar/0.8pre

I can't reproduce the main issue (1st issue in Comment #4) with a current build. Either the issue has been fixed by some other checkin or was only visible under Windows 2000 but not Windows XP. Unfortunately I no longer have access to Windows 2000 to verify.

Comment 10

[Simon Paquet [:sipaq]]

Philipp moved the relevant code statement from calendar-common-sets.xul to a separate function in calendar-unifinder.js in bug 411690 a few days ago (2008-01-18). Perhaps this is why you are no longer seeing this.

I suggest to test this on a build from 2008-01-17 on your WinXP box. If the issue still happens with that build, then Philipp fixed the issue and this bug is WFM.

Comment 11

[Simon Paquet [:sipaq]]

Stefan, could you verify that this only happens in builds before 2008-01-17 on WinXP?

Comment 12

[Simon Paquet [:sipaq]]

Not going to happen for 0.8.

Comment 13

[Stefan Sitter [:ssitter]]

Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8.1.13pre) Gecko/2008022007 Calendar/0.8pre

I can't reproduce this issue anymore, resolving WORKSFORME.