Closed
Bug 410159
Opened 18 years ago
Closed 18 years ago
nsAbLDAPProcessReplicationData::OpenABForReplicatedDir should get the replication file not the file name from nsIAbLDAPDirectory
Categories
(MailNews Core :: Address Book, defect)
MailNews Core
Address Book
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: standard8, Assigned: standard8)
References
Details
(Keywords: memory-footprint)
Attachments
(1 file)
|
1.96 KB,
patch
|
neil
:
review+
neil
:
superreview+
|
Details | Diff | Splinter Review |
In bug 394781 I provided a way in nsIAbLDAPDirectory to access the replication file as a complete nsILocalFile, so that callers didn't have to first get the file name, then get the profile directory and merge the two together.
I've just found a case in nsAbLDAPProcessReplicationData::OpenABForReplicatedDir where we should be re-using that function. Although we still have to extract the file name from the replication file, I think it looks a lot better and provides less reliance on nsIAddrBookSession::userProfileDirectory (which ideally I'd like to drop completely at some stage).
Attachment #294829 -
Flags: superreview?(neil)
Attachment #294829 -
Flags: review?(neil)
|
||
Updated•18 years ago
|
Attachment #294829 -
Flags: superreview?(neil)
Attachment #294829 -
Flags: superreview+
Attachment #294829 -
Flags: review?(neil)
Attachment #294829 -
Flags: review+
|
Assignee | |
Comment 1•18 years ago
|
||
Checked in -> fixed.
Status: ASSIGNED → RESOLVED
Closed: 18 years ago
Resolution: --- → FIXED
|
||
Updated•17 years ago
|
Product: Core → MailNews Core
You need to log in
before you can comment on or make changes to this bug.
Description
•