410346 - tagging URIs causes large increase in bookmarks observers

Status: RESOLVED FIXED

(Firefox :: Bookmarks & History, defect, P2)

Description

[Dietrich Ayala (:dietrich)]

every time you tag a URI, another bookmarks observer is added.

Comment 1

[Dietrich Ayala (:dietrich)]

Attachment: wallpaper

Comment 2

[Asaf Romano (gone)]

And that's caused by isURITaggedInternal I guess, doesn't the observer go away when the result is GCed?

Comment 3

[Asaf Romano (gone)]

er, closing containers does not remove the observer.

Comment 4

[Asaf Romano (gone)]

Attachment: patch

Comment 5

[Dietrich Ayala (:dietrich)]

Comment on attachment 294976 [details] [diff] [review]
patch

thanks, r=me.

however, this doesn't address the root cause of the reported issue, which seems to be that nsNavHistoryResult objects never get removed as bookmark observers. i'll file a follow up for that.

Comment 6

[Asaf Romano (gone)]

mozilla/toolkit/components/places/src/nsTaggingService.js 1.8

Comment 7

[Gervase Markham [:gerv]]

Bug 451915 - move Firefox/Places bugs to Firefox/Bookmarks and History. Remove all bugspam from this move by filtering for the string "places-to-b-and-h".

In Thunderbird 3.0b, you do that as follows:
Tools | Message Filters
Make sure the correct account is selected. Click "New"
Conditions: Body   contains   places-to-b-and-h
Change the action to "Delete Message".
Select "Manually Run" from the dropdown at the top.
Click OK.

Select the filter in the list, make sure "Inbox" is selected at the bottom, and click "Run Now". This should delete all the bugspam. You can then delete the filter.

Gerv