Closed
Bug 410501
Opened 18 years ago
Closed 18 years ago
Include account name in keychain entry names
Categories
(Camino Graveyard :: OS Integration, enhancement)
Tracking
(Not tracked)
RESOLVED
FIXED
Camino1.6
People
(Reporter: stuart.morgan+bugzilla, Assigned: stuart.morgan+bugzilla)
References
Details
(Keywords: fixed1.8.1.13)
Attachments
(1 file, 1 obsolete file)
|
7.40 KB,
patch
|
mikepinkerton
:
superreview+
|
Details | Diff | Splinter Review |
Once we store multiple accounts, we should set the name of the keychain item to include the username (like Safari) when storing or changing the username of an entry. I think kSecLabelItemAttr is the attribute in question, but I haven't tested.
|
Assignee | |
Updated•18 years ago
|
Summary: Include account name in → Include account name in keychain entry names
|
||
Comment 1•18 years ago
|
||
Right.
When we do this, we should be careful: when we change usernames instead of storing a new one in addition to the old, we need to make sure that the username for display is set properly, too. As I recall, Safari isn't (or wasn't?) quite so careful.
|
|
Assignee | |
Comment 2•18 years ago
|
||
Yeah, I'd noticed that Safari sucks at that, and was definitely planning to do better.
|
|
Assignee | |
Comment 3•18 years ago
|
||
Fixes both this bug and bug 410500 in a localizable way (without relying on stealing the localization from a system framework, since that seems fragile)
Attachment #305259 -
Flags: superreview?(mark)
|
|
Assignee | |
Comment 4•18 years ago
|
||
Oops, missed the header.
Attachment #305259 -
Attachment is obsolete: true
Attachment #305768 -
Flags: superreview?(mark)
Attachment #305259 -
Flags: superreview?(mark)
|
|
Assignee | |
Updated•18 years ago
|
Attachment #305768 -
Flags: superreview?(mark) → superreview?(mikepinkerton)
|
||
Comment 5•18 years ago
|
||
Comment on attachment 305768 [details] [diff] [review]
v2
sr=pink
Attachment #305768 -
Flags: superreview?(mikepinkerton) → superreview+
|
|
Assignee | |
Comment 6•18 years ago
|
||
Landed on trunk and MOZILLA_1_8_BRANCH.
Status: NEW → RESOLVED
Closed: 18 years ago
Keywords: fixed1.8.1.13
Resolution: --- → FIXED
Target Milestone: --- → Camino1.6
You need to log in
before you can comment on or make changes to this bug.
Description
•