410553 - Message Filters that only "Tag Message" aren't entered in filterlog.html

Status: RESOLVED FIXED

(MailNews Core :: Filters, defect)

Description

[Tim H.]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8.1.11) Gecko/20071128 Firefox/2.0.0.4
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8.1.11) Gecko/20071128 Firefox/2.0.0.4

When "Perform these actions:" section of "Filter Rules" dialog contains only a "Tag Message" action, the action is not logged in filterlog.html even though the tag is applied.


Reproducible: Always

Steps to Reproduce:
2.Compose a message with a unique subject and "Save"
3.Copy message from Draft folder to a temporary folder
1.Create message filter "Test" that only applies a tag when subject in (1) is matched
4.From "Tolls"->"Message Filters" dialog, select filter just created and "Run selected filter(s) on" the temporary folder
Actual Results:  
no entry in filter log

Expected Results:  
Applied filter "Test" to message from ... at 2008-01-02 14:01:31 Tagged as ...

Comment 1

[Tim H.]

Oops... numbers in 'Steps to Reproduce' should be 1,2,3,4 NOT 2,3,1,4

Comment 2

[Magnus Melin [:mkmelin]]

Confirming, moving to core. 

Comment 3

[Magnus Melin [:mkmelin]]

Attachment: proposed fix

The localization value for filterAction17 was missing.

Comment 4

[Magnus Melin [:mkmelin]]

The other "tagging" in the file is for the old label version. 

Comment 5

[David :Bienvenu]

Comment on attachment 295276 [details] [diff] [review]
proposed fix

thx, Magnus, yes, that was the problem.

Comment 6

[Magnus Melin [:mkmelin]]

Checking in mail/locales/en-US/chrome/messenger/filter.properties;
/cvsroot/mozilla/mail/locales/en-US/chrome/messenger/filter.properties,v  <--  filter.properties
new revision: 1.7; previous revision: 1.6
done
Checking in suite/locales/en-US/chrome/mailnews/filter.properties;
/cvsroot/mozilla/suite/locales/en-US/chrome/mailnews/filter.properties,v  <--  filter.properties
new revision: 1.23; previous revision: 1.22
done

->FIXED