410604 - IAccessible2::Get_UniqueID does not return negative IDs, as specified by IAccessible2 IDL

Status: VERIFIED FIXED

(Core :: Disability Access APIs, defect, major)

Description

[Marco Zehe (:MarcoZ)]

Following a discussion with Mick Curran in mozilla.dev.accessibility, it seems we are not returning negative unique IDs in the NSAccessibleWrap::Get_UniqueID method. See http://lxr.mozilla.org/seamonkey/source/accessible/src/msaa/nsAccessibleWrap.cpp#1316.

Comment 1

[Marco Zehe (:MarcoZ)]

Attachment: Make sure the value passed back from NSAccessibleWrap::Get_UniqueID is negative.

This patch is awaiting testing before I ask for Review. Comments welcome if it's OK to keep it this simple.

Comment 2

[Marco Zehe (:MarcoZ)]

Comment on attachment 295221 [details] [diff] [review]
Make sure the value passed back from NSAccessibleWrap::Get_UniqueID is negative.

Thanks for the review, Aaron! I also confirmed that this noww works as expected using Mick's test tool.

Comment 3

[Reed Loden [:reed] (use needinfo?)]

Checking in accessible/src/msaa/nsAccessibleWrap.cpp;
/cvsroot/mozilla/accessible/src/msaa/nsAccessibleWrap.cpp,v  <--  nsAccessibleWrap.cpp
new revision: 1.101; previous revision: 1.100
done

Comment 4

[Marco Zehe (:MarcoZ)]

Fix verified in Mozilla/5.0 (Windows; U; Windows NT 6.0; en-US; rv:1.9b3pre) Gecko/2008010605 Minefield/3.0b3pre using Mick's test tool.

Comment 5

[Akhil V Suku]

I am facing the same problem, that IAccessible2::Get_UniqueID is returning some garbage values, ie, consider I have two tabs, facebook.com and google.com, and facebook is selected first, 

if we check the  Get_UniqueID  it will be some -19000, after change the tab to google and when checking Get_UniqueID  will be -19054. when we again change the tab to facebook, it is supposed to give -19000 but result from Get_UniqueID   will be again some random number.

Thanks in advance.