STEPS TO REPRODUCE: =================== - convert a task or event into an eMail - check the subject of this eMail RESULT: ======= - the subject of this eMail is the event title with a leading 'Re:' EXPECTED RESULT: ================ - the subject should be the event title without the 'Re:' REPRODUCIBLE: ============= - always
Confirmed with Mozilla/5.0 (Windows; U; Windows NT 5.1; fr-FR; rv:22.214.171.124) Gecko/20070326 Thunderbird/126.96.36.199 ID:2007103104, Lightning 20080205
Version: Trunk → unspecified
VERIFIED Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:188.8.131.52) Gecko/20071031 Lightning/0.8pre (2008010520) Thunderbird/184.108.40.206 ID:2007103104
Little copy&paste error, the verified means confirmed ;-)
Not going to happen for 0.8.
Flags: wanted-calendar0.8? → wanted-calendar0.8-
Tested on Lightning 0.8pre (build 2008021620) Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:220.127.116.11) Gecko/20071031 Thunderbird/18.104.22.168 ID:2007103104
Assignee: nobody → firefox
Status: NEW → ASSIGNED
Attachment #304100 - Flags: review?(philipp)
Comment on attachment 304100 [details] [diff] [review] Removes 'Re:' from the subject >-emailSubjectReply=Re: %1$S >+emailSubjectReply=%1$S No use in having a string that is just a parameter. Please remove this string completely and change the calling code to directly use the parameter. This will be a post-0.8 bug due to string change.
Attachment #304100 - Flags: review?(philipp) → review-
http://lxr.mozilla.org/mozilla1.8/search?string=emailSubjectReply This string is used in multiple locations, e.g. if you want reply to the organizer of an invitation or compose an email message from the event dialog. In this case the Re: should probably preserved. But I agree that for the event creation it doesn't make much sense. In this case only http://lxr.mozilla.org/mozilla1.8/source/calendar/base/content/calendar-dnd-listener.js#450 ff. could be changed to directly use the title.
Philipp, Andreas, what do you think about Stefan proposal ?
Yes, Stefan's proposal makes sense. I wasn't aware the string was used in other cases.
In this case, we could even take this for 0.8, given ready in the next few days.
Updated to comments.
Comment on attachment 304329 [details] [diff] [review] Proposed fix >- var subject = calGetString("sun-calendar-event-dialog", >- "emailSubjectReply", >- [item.title]); >+ var subject = item.getProperty("SUMMARY"); > > // set up message body from item description > var body = item.getProperty("DESCRIPTION"); > > sendMailTo(recipients, subject, body); I'd suggest dropping the subject variable altogether and passing item.tite (not via getProperty) to sendMailTo directly. r+ with this changed, I can do so before checkin if you agree. > } > }, >
Attachment #304329 - Flags: review?(philipp) → review+
Dropped subject variable. Carrying over r+
Almost, the  are too much. Fixed this before checkin. Checked in on HEAD and MOZILLA_1_8_BRANCH -> FIXED
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Target Milestone: --- → 0.8
> Almost, the  are too much. yeah, but I saw [item.title] used in a few other places so... -> VERIFIED Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:22.214.171.124) Gecko/20071031 Lightning/0.8pre (2008022119) Thunderbird/126.96.36.199 ID:2007103104
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.