410721 - Forum topics are marked as not visited after a new topic is posted

Status: VERIFIED FIXED

(support.mozilla.org :: Forum, task)

Description

[Jason Barnabe (np)]

Topic links include topics_offset parameter, which causes every post to have a new URL after a new topic is posted. This makes Firefox think of the topic as a new page, and they are marked as not having been visited.

Can we remove this parameter? What does it do?

Comment 1

[Jason Barnabe (np)]

It looks like this may have to do with the next topic/previous topic feature. There should be a way to have that feature without passing a parameter in all the time - just go to the next or previous thread in that forum based on the time of the last post.

Comment 2

[Jason Barnabe (np)]

Attachment: remove prev/next topic

http://support.mozilla.com/tiki-view_forum_thread.php?comments_parentId=3253&topics_offset=3&topics_sort_mode=lastPost_desc&forumId=3

After some discussion with forum contributors, I think we can live without the next/previous topic feature.

Comment 3

[Jason Barnabe (np)]

It seems like the Tiki templates could use a URL generation function, something that takes a base and a hash of arguments and gives you a URL. I had to shift around a bunch of parameters because otherwise I would've ended up with a question mark then an ampersand in the URL after removing topics_offset.

Comment 4

[Nelson Ko [:nkoth]]

The "feature" for "prev/next topic" is actually implemented using a bunch of 4 params - topics_threshold, topics_offset, topics_find, and topics_sortmode. I have removed all 4.

Other than the change in tiki-view_forum.php, which is removing superflouus default vars anyway, I have not made any changes to php files. The templates have been modified to make this feature hidden.

Comment 5

[Jason Barnabe (np)]

Much shorter URLs are good :)

Comment 6

[Jason Barnabe (np)]

Now on live server.