410726 - address bar eats escaped newlines

Status: RESOLVED FIXED

(Firefox :: Address Bar, defect)

Description

[Simon Bünzli]

Steps to Reproduce:
1. Copy this bug's URL to the address bar and hit Enter.

Expected Results:
An alert reading "stab".

Actual result:
An alert reading "s	ab" (the newline separated \ from t - now they're interpreted as a <tab>).

Depending on how bug 397815 gets fixed, this issue might get fixed as well.

Comment 1

[Simon Bünzli]

So bug 397815 didn't fix this completely...

New Steps to Reproduce:
1. Copy&paste the following into the address bar and hit Enter/Go:
> data:text/plain,Percent:%20%25%0ANewline
2. Hit Enter again

Expected Result:
Nothing happens (two lines are displayed after both steps 1 and 2).

Actual Result:
After step 2, the newline vanishes.

I guess that's because the urlbar is set to newlines="stripsurroundingwhitespace" but whitespace isn't properly escaped at
http://bonsai.mozilla.org/cvsblame.cgi?file=mozilla/browser/base/content/browser.js&rev=1.925&mark=1909,1916#1881

>-        value = decodeURI(value).replace(/%/g, "%25");
>+        value = decodeURI(value).replace(/[%\r\n\t]/g, encodeURI);

would fix this issue for me.

Comment 2

[Dão Gottwald [:dao]]

(In reply to comment #1)
> >-        value = decodeURI(value).replace(/%/g, "%25");
> >+        value = decodeURI(value).replace(/[%\r\n\t]/g, encodeURI);
> 
> would fix this issue for me.

I think this makes sense. Would you like to take the bug?

Comment 3

[Dão Gottwald [:dao]]

Oops.

Comment 4

[Simon Bünzli]

Attachment: keep non-space whitespace encoded

See comment #4 for why we need to keep newlines and tabs encoded as well.

Comment 5

[Simon Bünzli]

s/comment #4/comment #1/

Comment 6

[Asaf Romano (gone)]

Comment on attachment 296754 [details] [diff] [review]
keep non-space whitespace encoded

r=mano

Comment 7

[:Gavin Sharp [email: [e-mail]]]

Why not just use \s?

Comment 8

[Simon Bünzli]

(In reply to comment #7)
Because we explicitly don't want to have %20 for plain spaces. At least that's how I understand the intention of these decoding bits.

Comment 9

[Reed Loden [:reed]]

Checking in browser/base/content/browser.js;
/cvsroot/mozilla/browser/base/content/browser.js,v  <--  browser.js
new revision: 1.928; previous revision: 1.927
done