410751 - BrowserPageInfo() in Firefox 3.0b2 breaks API compatibility with earlier versions of Firefox and with SeaMonkey

Status: RESOLVED FIXED

(Firefox :: Page Info Window, defect)

Description

[Philip Chee]

Attachment: Patch to make BrowserPageInfo() backward compatible.

In firefox 2.0:
  BrowserPageInfo(null, "securityTab");
In Minefield 3.0b2:
  BrowserPageInfo(null, "security");

This is the Firefox equivalent of a patch I filed against the Suite:
<https://bugzilla.mozilla.org/attachment.cgi?id=295015&action=edit>

I was porting the View Dependencies Page Info extension <http://mozilla.queze.net/> to the new Page Info in Minefield and SuiteRunner when I noticed this change. See Bug 410391 Comment #4 on why this might cause problems for extension authors adapting their extensions to the new Page Info window.

Since there is only one caller of BrowserPageInfo() that makes use of the second parameter, it doesn't make sense to optimize out the trailing "Tab" in the element ID passed to BrowserPageInfo(). Also this removes the unnecessary restriction on names of the element IDs ending with "Tabs".

This patch re-establishes backward compatibility and makes for a smoother experience by extension authors (like Florian Quèze)

Comment 1

[Florian Quèze [:florian]]

Comment on attachment 295342 [details] [diff] [review]
Patch to make BrowserPageInfo() backward compatible.

This change in the API looks silly. I can't even remember why I made it. I agree we should revert it.

Comment 2

[Philip Chee]

Do I still need a second review by mano? I am unfamiliar with the review rules for Firefox.

Comment 3

[Justin Wood (:Callek)]

Thanks for the CC and to quote from IRC for your answer Philip...

<Mossop> Callek: Florian isn't a browser peer so yes still needs review

Comment 4

[Asaf Romano (gone)]

Comment on attachment 295342 [details] [diff] [review]
Patch to make BrowserPageInfo() backward compatible.

r=mano

Comment 5

[Reed Loden [:reed]]

Checking in browser/base/content/browser.js;
/cvsroot/mozilla/browser/base/content/browser.js,v  <--  browser.js
new revision: 1.921; previous revision: 1.920
done
Checking in browser/base/content/pageinfo/pageInfo.js;
/cvsroot/mozilla/browser/base/content/pageinfo/pageInfo.js,v  <--  pageInfo.js
new revision: 1.14; previous revision: 1.13
done