410788 - remove dump statements

Status: VERIFIED FIXED

(Calendar :: General, defect)

Description

[Michiel van Leeuwen (email: mvl+moz@)]

There are a few dump statements that are always executed, even if there is no error. They are generally useless and just plain annoying. They should be removed.

Comment 1

[Michiel van Leeuwen (email: mvl+moz@)]

Attachment: patch v1

this patch makes those that I could find go away. It also fixes some js errors in sunbird.

Comment 2

[Philipp Kewisch [:Fallen][📱📆]]

Comment on attachment 295363 [details] [diff] [review]
patch v1

>-            dump ("*** Calendar schema version is: " + version + "\n");
>+            //dump ("*** Calendar schema version is: " + version + "\n");

>-
>+    
>+    /*
>     dump("Guessing system timezone:\n");
>     dump("TZoffset1: " + TZoffset1 + "\nTZoffset2: " + TZoffset2 + "\n");
>     if (TZname1 && TZname2) {
>         dump("TZname1: " + TZname1 + "\nTZname2: " + TZname2 + "\n");
>     }
>+    */

Why not get rid of this completely? I'm not a fan of commented out code checked in.

Otherwise r=philipp

Comment 3

[Michiel van Leeuwen (email: mvl+moz@)]

patch (updated) checked in

Comment 4

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

Browsed the source > VERIFIED.