remove dump statements

VERIFIED FIXED in 0.8

Status

VERIFIED FIXED
11 years ago
11 years ago

People

(Reporter: mvl, Unassigned)

Tracking

unspecified

Details

Attachments

(1 attachment)

There are a few dump statements that are always executed, even if there is no error. They are generally useless and just plain annoying. They should be removed.
Created attachment 295363 [details] [diff] [review]
patch v1

this patch makes those that I could find go away. It also fixes some js errors in sunbird.
Attachment #295363 - Flags: review?(philipp)
Comment on attachment 295363 [details] [diff] [review]
patch v1

>-            dump ("*** Calendar schema version is: " + version + "\n");
>+            //dump ("*** Calendar schema version is: " + version + "\n");

>-
>+    
>+    /*
>     dump("Guessing system timezone:\n");
>     dump("TZoffset1: " + TZoffset1 + "\nTZoffset2: " + TZoffset2 + "\n");
>     if (TZname1 && TZname2) {
>         dump("TZname1: " + TZname1 + "\nTZname2: " + TZname2 + "\n");
>     }
>+    */

Why not get rid of this completely? I'm not a fan of commented out code checked in.

Otherwise r=philipp
Attachment #295363 - Flags: review?(philipp) → review+
patch (updated) checked in
Status: NEW → RESOLVED
Last Resolved: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → 0.8
Browsed the source > VERIFIED.
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.