Closed Bug 410788 Opened 17 years ago Closed 17 years ago

remove dump statements

Categories

(Calendar :: General, defect)

defect
Not set
normal

Tracking

(Not tracked)

VERIFIED FIXED

People

(Reporter: mvl, Unassigned)

Details

Attachments

(1 file)

There are a few dump statements that are always executed, even if there is no error. They are generally useless and just plain annoying. They should be removed.
Attached patch patch v1Splinter Review
this patch makes those that I could find go away. It also fixes some js errors in sunbird.
Attachment #295363 - Flags: review?(philipp)
Comment on attachment 295363 [details] [diff] [review]
patch v1

>-            dump ("*** Calendar schema version is: " + version + "\n");
>+            //dump ("*** Calendar schema version is: " + version + "\n");

>-
>+    
>+    /*
>     dump("Guessing system timezone:\n");
>     dump("TZoffset1: " + TZoffset1 + "\nTZoffset2: " + TZoffset2 + "\n");
>     if (TZname1 && TZname2) {
>         dump("TZname1: " + TZname1 + "\nTZname2: " + TZname2 + "\n");
>     }
>+    */

Why not get rid of this completely? I'm not a fan of commented out code checked in.

Otherwise r=philipp
Attachment #295363 - Flags: review?(philipp) → review+
patch (updated) checked in
Status: NEW → RESOLVED
Closed: 17 years ago
Resolution: --- → FIXED
Target Milestone: --- → 0.8
Browsed the source > VERIFIED.
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: