410823 - Bugzilla fails when editing or deleting a multi-select field value

Status: RESOLVED FIXED

(Bugzilla :: Administration, task)

Description

[Ronaldo Maia]

Attachment: check if the field is a multi-select and handle it properly

When trying to edit the value of a multi-select option this error appears:

DBD::mysql::db do failed: Unknown column 'cf_multi' in 'where clause' [for Statement "UPDATE bugs SET cf_multi = ? WHERE cf_multi = ?"]

Comment 1

[Frédéric Buclin]

Comment on attachment 295398 [details] [diff] [review]
check if the field is a multi-select and handle it properly

This fixes the problem when editing a value, but deleting one still fails:

DBD::mysql::db selectrow_array failed: Unknown column 'cf_audience' in 'where clause' [for Statement "SELECT COUNT(*) FROM bugs WHERE cf_audience = ?"] at /var/www/html/bugzilla/editvalues.cgi line 275

Please fix that in this bug as well.

Comment 2

[Frédéric Buclin]

We need a Selenium script testing all custom field formats.

Comment 3

[Ronaldo Maia]

Attachment: v2 - also fix error when deleting a value.

Comment 4

[Frédéric Buclin]

Comment on attachment 295404 [details] [diff] [review]
v2 - also fix error when deleting a value.

Works fine. Note that these || 0 are useless and can be safely removed. I will remove them on checkin. r=LpSolit

Comment 5

[Frédéric Buclin]

Checking in editvalues.cgi;
/cvsroot/mozilla/webtools/bugzilla/editvalues.cgi,v  <--  editvalues.cgi
new revision: 1.27; previous revision: 1.26
done