Bugzilla fails when editing or deleting a multi-select field value

RESOLVED FIXED in Bugzilla 3.2

Status

()

Bugzilla
Administration
--
major
RESOLVED FIXED
11 years ago
11 years ago

People

(Reporter: Ronaldo Maia, Assigned: Ronaldo Maia)

Tracking

3.1.1
Bugzilla 3.2
Bug Flags:
approval +
blocking3.1.3 +
testcase ?

Details

Attachments

(1 attachment, 1 obsolete attachment)

(Assignee)

Description

11 years ago
Created attachment 295398 [details] [diff] [review]
check if the field is a multi-select and handle it properly

When trying to edit the value of a multi-select option this error appears:

DBD::mysql::db do failed: Unknown column 'cf_multi' in 'where clause' [for Statement "UPDATE bugs SET cf_multi = ? WHERE cf_multi = ?"]
Attachment #295398 - Flags: review?(LpSolit)

Comment 1

11 years ago
Comment on attachment 295398 [details] [diff] [review]
check if the field is a multi-select and handle it properly

This fixes the problem when editing a value, but deleting one still fails:

DBD::mysql::db selectrow_array failed: Unknown column 'cf_audience' in 'where clause' [for Statement "SELECT COUNT(*) FROM bugs WHERE cf_audience = ?"] at /var/www/html/bugzilla/editvalues.cgi line 275

Please fix that in this bug as well.
Attachment #295398 - Flags: review?(LpSolit) → review+

Updated

11 years ago
Flags: blocking3.1.3+
Summary: Multi-select fields values are not editable. → Bugzilla fails when editing or deleting a multi-select field value

Updated

11 years ago
Depends on: 287330

Comment 2

11 years ago
We need a Selenium script testing all custom field formats.
Flags: testcase?
(Assignee)

Comment 3

11 years ago
Created attachment 295404 [details] [diff] [review]
v2 - also fix error when deleting a value.
Attachment #295398 - Attachment is obsolete: true
Attachment #295404 - Flags: review?(LpSolit)

Comment 4

11 years ago
Comment on attachment 295404 [details] [diff] [review]
v2 - also fix error when deleting a value.

Works fine. Note that these || 0 are useless and can be safely removed. I will remove them on checkin. r=LpSolit
Attachment #295404 - Flags: review?(LpSolit) → review+

Updated

11 years ago
Flags: approval+

Comment 5

11 years ago
Checking in editvalues.cgi;
/cvsroot/mozilla/webtools/bugzilla/editvalues.cgi,v  <--  editvalues.cgi
new revision: 1.27; previous revision: 1.26
done
Status: ASSIGNED → RESOLVED
Last Resolved: 11 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.