410948 - When CZ is opened in a tab, show CZ icon on tabbar.

Status: RESOLVED FIXED

(Other Applications :: ChatZilla, enhancement)

Description

[Ryan S. Scheel [:havvy]]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9b2) Gecko/2007121120 Firefox/3.0b2
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9b2) Gecko/2007121120 Firefox/3.0b2

Basically, when you open up CZ in a tab, I would like the tab to have an icon.  It would make it easier for me to locate CZ out of all the other tabs on the bar and improve satisfaction with the program.

Reproducible: Always

Steps to Reproduce:
With CZ installed, but this into the locationbar:  chrome://chatzilla/content/

Notice that there is no icon for it, and the default shows up.

Comment 1

[:Gijs (he/him)]

I'm pretty sure this is CANTFIX, but whatever - it's a valid request, at least.

Comment 2

[Mitchell Field [:Mitch]]

Attachment: Patch v1.0

Comment 3

[:Gijs (he/him)]

Comment on attachment 311382 [details] [diff] [review]
Patch v1.0

Assuming this works (ie, you've tested it on Fx 2 and 3, at least), r=me. Totally crazy that it works, though...

Comment 4

[:Gijs (he/him)]

Checking in mozilla/extensions/irc/xul/content/chatzilla.xul;
/cvsroot/mozilla/extensions/irc/xul/content/chatzilla.xul,v  <--  chatzilla.xul
new revision: 1.73; previous revision: 1.72
done

Comment 5

[[e-mail]]

(In reply to comment #3)
>(From update of attachment 311382 [details] [diff] [review])
>Assuming this works (ie, you've tested it on Fx 2 and 3, at least), r=me.
>Totally crazy that it works, though...
Well, it works unless you have a third-party theme that doesn't have that image at that precise location... maybe a content url would have been better?

Comment 6

[:Gijs (he/him)]

(In reply to comment #5)
> (In reply to comment #3)
> >(From update of attachment 311382 [details] [diff] [review])
> >Assuming this works (ie, you've tested it on Fx 2 and 3, at least), r=me.
> >Totally crazy that it works, though...
> Well, it works unless you have a third-party theme that doesn't have that image
> at that precise location... maybe a content url would have been better?
> 

If the theme doesn't provide stuff, anything can and will break in terms of styling. On the plus side, this allows the themes to provide things and change the appearance of things, which was kind of the point of them in the first place.

Comment 7

[James Ross]

I think when we put in the updated logo images for the about dialog (bug 420589), they'll be in content (since it is branding), and we can change the URL used here.

For now, though, this is an acceptable issue (if it's not found, you should get the old behaviour from the browser, if not, file a browser bug).