If you think a bug might affect users in the 57 release, please set the correct tracking and status flags for Release Management.

Duplicate access keys in Views > Sort in Places Organizer

RESOLVED FIXED in Firefox 3 beta3

Status

()

Firefox
Menus
--
minor
RESOLVED FIXED
10 years ago
10 years ago

People

(Reporter: Ehsan, Assigned: Ehsan)

Tracking

({access, polish})

Trunk
Firefox 3 beta3
access, polish
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

Created attachment 295607 [details] [diff] [review]
Patch (v1)

Gavin: this is the next one in my duplicate access keys series.  :-)

The Views > Sort menu in Places Organizer (a.k.a Library) contains two entries with access key (A): "Sort by Added" and "A > Z Sort Order".  Since (A) makes a lot of sense as the access key for "A > Z Sort Order" (and contrasts the access key for "_Z_ > A Sort Order" nicely), we'll keep it, and change the access key for "Sort by Added" to (e).

This patch implements this change.
Attachment #295607 - Flags: review?(gavin.sharp)
Hmmm, now that I think, Firefox :: Menus seems to be a better place for this bug...
Assignee: ehsan.akhgari → nobody
Status: ASSIGNED → NEW
Component: Places → Menus
QA Contact: places → menus
Target Milestone: --- → Firefox 3 M11
Assignee: nobody → ehsan.akhgari
Status: NEW → ASSIGNED
Comment on attachment 295607 [details] [diff] [review]
Patch (v1)

This needs some acceleration because the l10n freeze is near.
Attachment #295607 - Flags: ui-review?(beltzner)
Attachment #295607 - Flags: review?(mano)
Attachment #295607 - Flags: review?(gavin.sharp)
Comment on attachment 295607 [details] [diff] [review]
Patch (v1)

We could sure do it after l10n freeze, but r=me anyway :p

You don't need ui-r here.
Attachment #295607 - Flags: ui-review?(beltzner)
Attachment #295607 - Flags: review?(mano)
Attachment #295607 - Flags: review+
Comment on attachment 295607 [details] [diff] [review]
Patch (v1)

Seeking approval on this.  This is a polish issue and the change is pretty low-risk.
Attachment #295607 - Flags: approval1.9?
Comment on attachment 295607 [details] [diff] [review]
Patch (v1)

a=beltzner for 1.9
Attachment #295607 - Flags: approval1.9? → approval1.9+
Keywords: checkin-needed
Checking in browser/locales/en-US/chrome/browser/places/places.properties;
/cvsroot/mozilla/browser/locales/en-US/chrome/browser/places/places.properties,v  <--  places.properties
new revision: 1.35; previous revision: 1.34
done
Status: ASSIGNED → RESOLVED
Last Resolved: 10 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.