Closed Bug 411028 Opened 12 years ago Closed 12 years ago

Migrate SeaMonkey's history preference pane to new pref window

Categories

(SeaMonkey :: Preferences, defect)

defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED
seamonkey2.0a1

People

(Reporter: stefanh, Assigned: stefanh)

References

Details

Attachments

(2 files, 2 obsolete files)

Attached patch Migrate the panel (obsolete) — Splinter Review
I also re-indented pref-history.xul while I was at it... -w diff coming.
Attachment #295636 - Flags: review?(neil)
This one is probably easier to look at.
Comment on attachment 295636 [details] [diff] [review]
Migrate the panel

IanN pointed out some issues on irc ...
Attachment #295636 - Flags: review?(neil)
Attached patch New versionSplinter Review
As IanN pointed out, the disable_button prefs should be bool ones... I tested disabling the buttons by locking the prefs with the value set to true, and it seemed to work.
Attachment #295636 - Attachment is obsolete: true
Attachment #295637 - Attachment is obsolete: true
Attachment #295702 - Flags: review?(neil)
Status: NEW → ASSIGNED
Comment on attachment 295703 [details] [diff] [review]
-w version (complete patch)

>+function prefClearUrlbarHistory()
>+{
>+  document.getElementById("general.open_location.last_url").value = "";
The problem here is that this only works in instant apply mode. I think changing this to use valueFromPreferences will work.
Comment on attachment 295702 [details] [diff] [review]
New version

Assuming that that change works, r=me with it fixed.
Attachment #295702 - Flags: review?(neil) → review+
(In reply to comment #6)
> (From update of attachment 295702 [details] [diff] [review])
> Assuming that that change works, r=me with it fixed.
> 
I changed "browser.preferences.instantApply" to false and tried - semms to work fine.

Checking in suite/common/pref/pref-history.js;
/cvsroot/mozilla/suite/common/pref/pref-history.js,v  <--  pref-history.js
initial revision: 1.1
done
Checking in suite/common/pref/pref-history.xul;
/cvsroot/mozilla/suite/common/pref/pref-history.xul,v  <--  pref-history.xul
new revision: 1.34; previous revision: 1.33
done
Checking in suite/common/pref/preferences.xul;
/cvsroot/mozilla/suite/common/pref/preferences.xul,v  <--  preferences.xul
new revision: 1.7; previous revision: 1.6
done
Checking in suite/common/pref/preftree.xul;
/cvsroot/mozilla/suite/common/pref/preftree.xul,v  <--  preftree.xul
new revision: 1.111; previous revision: 1.110
done
Checking in suite/common/jar.mn;
/cvsroot/mozilla/suite/common/jar.mn,v  <--  jar.mn
new revision: 1.39; previous revision: 1.38
done

Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Target Milestone: --- → seamonkey2.0alpha
You need to log in before you can comment on or make changes to this bug.