411029 - Middle-mouse click on bookmark folder in empty window does not replace existing about:blank tab

Status: RESOLVED INACTIVE

(Firefox :: Bookmarks & History, defect)

Description

[bugzillamozilla05]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9b2) Gecko/2007121120 Firefox/3.0b2
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9b2) Gecko/2007121120 Firefox/3.0b2

When in an newly opened window I open a bookmark folder into multiple tabs by selecting "Open All in Tabs", that works as expected. When I middle-mouse-click on the folder name, however, an additional empty tab is created (or rather, it is not deleted).

Reproducible: Always

Steps to Reproduce:
1. Ctrl-N to open new window
2. Click on Bookmarks menu (this makes the Bookmark this Page dialogue appear for "about:blank", I've described this bug separately; type Esc to make the dialogue disappear)
3. Click middle mouse button on bookmark sub-folder (should Open All in Tabs)
Actual Results:  
All sub-folder contents are opened in separate tabs, as should be, but an additional empty tab remains.

Expected Results:  
All sub-folder contents should be opened in separate tabs, with no additional empty tab being created (or left unremoved).

Comment 1

[Ria Klaassen (not reading all bugmail)]

Trying to reproduce this, I started Firefox 3 with a new profile with only a bookmarks.html in it.
I clicked on the Bookmarks menu (I saw no Add Bookmarks dialog). When I middle clicked on a folder all 12 items were opened in new tabs. It didn't overwrite the already open tab but created 12 additional tabs so there are 13 open tabs in total now.
If this is the problem, this bug is a duplicate of Bug 409122. 

Comment 3

[Tyler Downer [He/Him]]

WFM in Mozilla/5.0 (Windows; U; Windows NT 6.0; en-US; rv:1.9.1b3pre)
Gecko/20081213 Shiretoko/3.1b3pre. Can you read
http://new.quality.mozilla.org/bug-writing-guidelines and get back with results
on a modern (3.0.4 is good0 version of Firefox.

Comment 4

[Marco Bonardo [:mak]]

no answer from original reporter, possible a dupe (see comment 1), but incomplete

Comment 5

[bugzillamozilla05]

Apologies for the delay, I've been offline for a while.

No, Bug 409122, which has been marked as duplicate of Bug 395024 is not a duplicate of This Report, but describes a complementary observation, so the two might be related.

Essentially the other bug report says that even if you have browser.tabs.loadFolderAndReplace set to "false", using the "open all in tabs" command on a group of bookmarks loads the first tab in your current tab and then inserts the remaining new tabs to the right of that existing, overwritten tab.
This is true when using the "open all in tabs" bookmarks menu entry.
Also, when browser.tabs.loadFolderAndReplace is set to "true", this is the *desired* behaviour.

However, this does not happen when middle-clicking the folder name in the Bookmarks menu. In that case, the current tab is *not* overwritten, and the remaining tabs are inserted to the right, even when the current tab is *empty*.

So, the bug I reported here is:
a) different behaviour for middle-click on Bookmark Folder vs using "open all in tabs"
b) for "middle-click" on a Bookmark Folder in a newly opened empty window, the first opened tab does not replace the current "empty tab".

Comment 6

[bugzillamozilla05]

(In reply to comment #3)
> WFM in Mozilla/5.0 (Windows; U; Windows NT 6.0; en-US; rv:1.9.1b3pre)
> Gecko/20081213 Shiretoko/3.1b3pre. Can you read
> http://new.quality.mozilla.org/bug-writing-guidelines and get back with results
> on a modern (3.0.4 is good0 version of Firefox.

The problem persists exactly as described here for since the 3.0beta2 on the latest released versions of Firefox (tried 3.0.4 and 3.0.5) on Windows XP and Windows 2000.

Comment 7

[Josh Triplett]

Reopening this bug.  It continues to exist in Firefox 6, exactly as described by the reporter in comment 5.  Left-clicking and "open all in tabs" replaces the current tab, but middle-clicking the folder does not replace the current tab, even if the current tab is about:blank.  Thus, if I open a fresh instance of Firefox and middle-click on a bookmark folder, I get all the bookmarks from that folder, with about:blank remaining at the far left.

Comment 8

[Marco Bonardo [:mak]]

fwiw, now behavior is the same for middle click or open all in tabs, we don't override empty blank pages, see also bug 683146 (adding a dep to have these linked)

Comment 9

[Nicolas Barbulesco]

That's normal. Let's keep it that way, for consistency's sake.
The semantics of the middle click are : new tab. So, at middle click, Firefox should not puzzle the user by opening stuff in the current tab.
Discussing that issue further in request bug 683146…

Comment 10

[BMO Automation]

Per policy at https://wiki.mozilla.org/Bug_Triage/Projects/Bug_Handling/Bug_Husbandry#Inactive_Bugs. If this bug is not an enhancement request or a bug not present in a supported release of Firefox, then it may be reopened.