De-gecko-ize Privacy

RESOLVED FIXED in Camino1.6

Status

Camino Graveyard
Preferences
RESOLVED FIXED
9 years ago
9 years ago

People

(Reporter: Stuart Morgan, Assigned: Stuart Morgan)

Tracking

({fixed1.8.1.12})

unspecified
Camino1.6
x86
Mac OS X
fixed1.8.1.12

Details

Attachments

(2 attachments)

fix
58.74 KB, patch
Mark Mentovai
: superreview+
Details | Diff | Splinter Review
nib
21.66 KB, application/octet-stream
Details
(Assignee)

Description

9 years ago
This adds a wrapper around the cookie manager that vends cookies from core as NSHTTPCookies. With that, Privacy can get off of direct Gecko use entirely, and stop linking libxpcom_core.

There's almost certainly more consolidation of code that could be done (along the lines of what I did in the table header click handler) now that all the sheets work basically the same way, but I'll save that for another day.
(Assignee)

Comment 1

9 years ago
Created attachment 295704 [details] [diff] [review]
fix
Attachment #295704 - Flags: superreview?(mark)
(Assignee)

Comment 2

9 years ago
Created attachment 295705 [details]
nib

Corresponding nib; it just changes the column identifiers to match the NSHTTPCookie keys.

Comment 3

9 years ago
Comment on attachment 295704 [details] [diff] [review]
fix

Are you going to take the Gecko libs out of the target in the project file too, or are you going to wait until all of these are done?

Did you add the new header to the prefpane's copy headers phase?

This looks like it was an annoying job, nice work.  New bug to share more of the sheet'n'table stuff, the three really are now all pretty much identical.
Attachment #295704 - Flags: superreview?(mark) → superreview+

Comment 4

9 years ago
Also, make sure you've tried building this with Xcode 2.x to make sure we don't need that little .asm block to keep its ld from dead-stripping .objc_class_name_CHCookieStorage like we had to do here:

http://bonsai.mozilla.org/cvsblame.cgi?file=/mozilla/camino/src/browser/AppListMenuFactory.mm&rev=1.10&mark=42-43#39
http://bonsai.mozilla.org/cvsblame.cgi?file=/mozilla/camino/src/formfill/KeychainDenyList.mm&rev=1.2&mark=42-43#39
(Assignee)

Comment 5

9 years ago
Landed on trunk and MOZILLA_1_8_BRANCH with additional target cleanup (and similar cleanup for the Security pane), and the asm directive for Xcode 2.x.
Status: NEW → RESOLVED
Last Resolved: 9 years ago
Keywords: fixed1.8.1.12
Resolution: --- → FIXED
Target Milestone: --- → Camino1.6
You need to log in before you can comment on or make changes to this bug.