Last Comment Bug 411071 - De-gecko-ize Privacy
: De-gecko-ize Privacy
Status: RESOLVED FIXED
: fixed1.8.1.12
Product: Camino Graveyard
Classification: Graveyard
Component: Preferences (show other bugs)
: unspecified
: x86 Mac OS X
: -- normal (vote)
: Camino1.6
Assigned To: Stuart Morgan
:
Mentors:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2008-01-06 17:52 PST by Stuart Morgan
Modified: 2008-01-07 13:34 PST (History)
3 users (show)
See Also:
QA Whiteboard:
Iteration: ---
Points: ---


Attachments
fix (58.74 KB, patch)
2008-01-06 17:53 PST, Stuart Morgan
mark: superreview+
Details | Diff | Splinter Review
nib (21.66 KB, application/octet-stream)
2008-01-06 17:54 PST, Stuart Morgan
no flags Details

Description Stuart Morgan 2008-01-06 17:52:01 PST
This adds a wrapper around the cookie manager that vends cookies from core as NSHTTPCookies. With that, Privacy can get off of direct Gecko use entirely, and stop linking libxpcom_core.

There's almost certainly more consolidation of code that could be done (along the lines of what I did in the table header click handler) now that all the sheets work basically the same way, but I'll save that for another day.
Comment 1 Stuart Morgan 2008-01-06 17:53:23 PST
Created attachment 295704 [details] [diff] [review]
fix
Comment 2 Stuart Morgan 2008-01-06 17:54:11 PST
Created attachment 295705 [details]
nib

Corresponding nib; it just changes the column identifiers to match the NSHTTPCookie keys.
Comment 3 Mark Mentovai 2008-01-07 11:41:05 PST
Comment on attachment 295704 [details] [diff] [review]
fix

Are you going to take the Gecko libs out of the target in the project file too, or are you going to wait until all of these are done?

Did you add the new header to the prefpane's copy headers phase?

This looks like it was an annoying job, nice work.  New bug to share more of the sheet'n'table stuff, the three really are now all pretty much identical.
Comment 4 Mark Mentovai 2008-01-07 12:30:02 PST
Also, make sure you've tried building this with Xcode 2.x to make sure we don't need that little .asm block to keep its ld from dead-stripping .objc_class_name_CHCookieStorage like we had to do here:

http://bonsai.mozilla.org/cvsblame.cgi?file=/mozilla/camino/src/browser/AppListMenuFactory.mm&rev=1.10&mark=42-43#39
http://bonsai.mozilla.org/cvsblame.cgi?file=/mozilla/camino/src/formfill/KeychainDenyList.mm&rev=1.2&mark=42-43#39
Comment 5 Stuart Morgan 2008-01-07 13:34:06 PST
Landed on trunk and MOZILLA_1_8_BRANCH with additional target cleanup (and similar cleanup for the Security pane), and the asm directive for Xcode 2.x.

Note You need to log in before you can comment on or make changes to this bug.