Closed Bug 411092 Opened 17 years ago Closed 17 years ago

XPCNativeWrapper pollution using setTimeout()

Categories

(Core :: XPConnect, defect, P1)

Product:
Core
Component:
XPConnect
Type:
defect

Tracking

()

Status:
RESOLVED FIXED

People

(Reporter: moz_bug_r_a4, Assigned: mrbkap)

Details

(Keywords: testcase, verified1.8.1.13, Whiteboard: [sg:critical] fixes 414749 also)

Attachments

(3 files, 1 obsolete file)

patch v2
5.71 KB, patch
jst
: review+
jst
: superreview+
Details | Diff | Splinter Review
Branch patch
5.92 KB, patch
jst
: review+
jst
: superreview+
dveditz
: approval1.8.1.13+
asac
: approval1.8.0.next?
Details | Diff | Splinter Review
1.8.0 clean
5.73 KB, patch
Details | Diff | Splinter Review
A script that setTimeout(code) creates inherits its scripted caller's script filename. Thus, it's possible to use setTimeout() in the same way as bug 369211 and bug 387881 to modify XPCNativeWrappers.
Assignee: dveditz → nobody
Component: Security → XPConnect
Flags: blocking1.9?
Flags: blocking1.8.1.12?
QA Contact: toolkit → xpconnect
Whiteboard: [sg:critical]
Keywords: testcase
OS: Windows XP → All
Hardware: PC → All
Blake, any hope to get a fix for this one similar to the other wrapper pollution ones you're fixing?
Flags: wanted1.8.1.x+
Flags: blocking1.8.1.12?
Flags: blocking1.8.1.12+
Assignee: nobody → mrbkap
Priority: -- → P1
Flags: blocking1.9? → blocking1.9+
No tested trunk fix, not going to make 1.8.1.12 either
Flags: blocking1.8.1.12+ → blocking1.8.1.13+
Attached patch patch v1 (obsolete) — — Splinter Review
This patch feels a little fragile to me, but it works.
Attachment #299453 - Flags: superreview?(jst)
Attachment #299453 - Flags: review?(jst)
Comment on attachment 299453 [details] [diff] [review] patch v1 Looks right to me. r+sr=jst
Attachment #299453 - Flags: superreview?(jst)
Attachment #299453 - Flags: superreview+
Attachment #299453 - Flags: review?(jst)
Attachment #299453 - Flags: review+
This works on current trunk. (testcase 1 no longer works on trunk due to the fix for bug 397791.)
Attached patch patch v2 — — Splinter Review
After some thought, I realized what was bugging me was a missing 'subsumes' check. Now this code works both ways.
Attachment #299453 - Attachment is obsolete: true
Attachment #300182 - Flags: superreview?(jst)
Attachment #300182 - Flags: review?(jst)
Attachment #299453 - Flags: superreview+
Attachment #299453 - Flags: review+
Attachment #300182 - Flags: superreview?(jst)
Attachment #300182 - Flags: superreview+
Attachment #300182 - Flags: review?(jst)
Attachment #300182 - Flags: review+
Fix checked into trunk.
Status: NEW → RESOLVED
Closed: 17 years ago
Resolution: --- → FIXED
Flags: in-testsuite?
Note bug 414749 as a followup.
Attached patch Branch patch — — Splinter Review
This rolls in the patch for bug 414749 as well. It's so much easier without the DOM agnostic stuff!
Attachment #307125 - Flags: superreview?(jst)
Attachment #307125 - Flags: review?(jst)
Attachment #307125 - Flags: approval1.8.1.13?
Attachment #307125 - Flags: superreview?(jst)
Attachment #307125 - Flags: superreview+
Attachment #307125 - Flags: review?(jst)
Attachment #307125 - Flags: review+
Comment on attachment 307125 [details] [diff] [review] Branch patch approved for 1.8.1.13, a=dveditz for release-drivers
Attachment #307125 - Flags: approval1.8.1.13? → approval1.8.1.13+
When this is checked into the branch please mark bug 414749 with "fixed1.8.1.13" as well
Whiteboard: [sg:critical] → [sg:critical] fixes 414749 also
Fixed on the 1.8 branch.
Keywords: fixed1.8.1.13
Verified in 1.8 branch with Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8.1.13) Gecko/2008031114 Firefox/2.0.0.13 and bug verified with 2.0.0.12.
Keywords: fixed1.8.1.13 → verified1.8.1.13
Comment on attachment 307125 [details] [diff] [review] Branch patch applies to 1.8.0 with slight adjustments (will attach a helper attachment with the distro patch). caillon, please sign off
Attachment #307125 - Flags: approval1.8.0.15?
Attached patch 1.8.0 clean — — Splinter Review
Flags: blocking1.8.0.15+
Group: security
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: