41110 - remove nsIWebshellWindow/nsIXULWindow usage

Status: RESOLVED FIXED

(Core :: DOM: Navigation, task, P3)

Description

[Judson Valeski]

nsIWebshellWindow/nsIXULWindow usage needs to be removed (except for code using
the appshell service directly). This will allow all window users to utilize
embedded windows (which do not support nsIWebshellWindow/nsIXULWindow.

Comment 1

[Judson Valeski]

nominating nsbeta2. This is fairly ongoing work, but I need to progressively 
check changes in, and I want to abide by the rules.

Comment 2

[leger]

Putting on [nsbeta2-] radar. Not needed for beta2, but come see PDT when you 
have stuff to check in and we'll work something out.

Comment 3

[Mike]

M16 has been out for a while now, these bugs target milestones need to be 
updated.

Comment 4

[Judson Valeski]

pulling off of embedding radar. this should be cleaned up for internal usage,
but we're ok for now on the exposed api front.

Comment 5

[Dan M]

.

Comment 6

[Hixie (not reading bugmail)]

Is this still needed, or have more recent arch changes made this irrelevant?

Comment 7

[Boris Zbarsky [:bzbarsky]]

These interfaces are still used by the cached compose window stuff in mailnews
as well as nsMsgPrintEngine::ShowWindow (also mailnews).  Leaving this is ok, I
think...

The photon widget impl uses nsIXULWindow (to get docshells).  This is pretty bogus.

The rest of the usage seems to be under xpfe.  The appshell, bootstrap, and XUL
users are all fine; I dunno about the
xpfe/components/windowds/nsWindowDataSource.cpp user, since I have no clue what
it does.

Comment 8

[[e-mail]]

nsWindowDataSource.cpp is the guts behind the window menu, it was split off from
the window mediator to remove the RDF dependency.

Comment 9

[Boris Zbarsky [:bzbarsky]]

OK.  So sounds like the photon widget impl is all that's left on the way to
marking this bug fixed?

Comment 10

[Hsin-Yi Tsai (she/her) [:hsinyi]]

nsIWebshellWindow/nsIXULWindow are no longer in the m-c code base.