411206 - warning : function addItem does not always return a value

Status: VERIFIED DUPLICATE of bug 409968

(Calendar :: Lightning Only, defect)

Description

[Matp75]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; fr; rv:1.9b2) Gecko/2007121120 Firefox/3.0b2
Build Identifier: 0.8pre 2007010803 with thunderbird 2

Avertissement : function addItem does not always return a value
Fichier source : chrome://lightning/content/agenda-listbox.js
Ligne : 251, Colonne : 19
Code source :
        return null; 


Reproducible: Always

Steps to Reproduce:
1.Launch Thunderbird + Lightning
2.Open console (using console 2 extension)
3.look for warning messages
Actual Results:  
warning message

Expected Results:  
no warning

agendaListbox.addItem =
function addItem(aItem) {
    if (!isEvent(aItem)) {
        return;     // real error is here, should return null in my opinion
    }
    var periods = this.findPeriodsForItem(aItem);
    if (periods.length == 0) {
        return null;     // line 219 here -> warning
    }

Please change the return for return null to suppress this warning

Comment 1

[Matp75]

There are many other occurence of the same problem in the same file.
Please correct them all at the same time.

Avertissement : function observer_onLocalDeleteItem does not always return a value
Fichier source : chrome://lightning/content/agenda-listbox.js
Ligne : 650, Colonne : 21
Code source :
    return isSelected; 

Comment 2

[Berend Cornelius]

I've noticed this already and fixed these occurrences "on the way" in bug 409968. I hope it's Ok to set the state to 'duplicate'

Comment 3

[Matp75]

That's fine.
Great to know it will be fixed soon.
Thanks