411384 - [Mac] Dragging Local files to Bookmarks Toolbar does not work

Status: RESOLVED FIXED

(Firefox :: Bookmarks & History, defect, P3)

Description

[Marcia Knous [:marcia]]

Seen using Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9b3pre) Gecko/2008010804 Minefield/3.0b3pre.

STR:
1. Start Firefox
2. Drag any file, html, text, xpi, etc to the Bookmarks Toolbar

Actual Results:  
Unable to add the bookmark. No error in console.

Bug 336286 was filed for Windows and Linux but it seems to work on those two operating systems.

Comment 1

[Martijn Wargers (dead)]

Since bug 336286 was blocking-firefox3+, it seems to me this should block too.

Comment 2

[Mike Connor [:mconnor]]

Not blocking on this bug for final ship. Would take a safe enough patch if one comes through.

Comment 3

[Gervase Markham [:gerv]]

Bug 451915 - move Firefox/Places bugs to Firefox/Bookmarks and History. Remove all bugspam from this move by filtering for the string "places-to-b-and-h".

In Thunderbird 3.0b, you do that as follows:
Tools | Message Filters
Make sure the correct account is selected. Click "New"
Conditions: Body   contains   places-to-b-and-h
Change the action to "Delete Message".
Select "Manually Run" from the dropdown at the top.
Click OK.

Select the filter in the list, make sure "Inbox" is selected at the bottom, and click "Run Now". This should delete all the bugspam. You can then delete the filter.

Gerv

Comment 4

[Logan Rosen [:Logan]]

Attachment: Bug 411384 - Enable dragging files to create bookmarks on macOS. r?#mac-reviewers

When a file is dragged on macOS to Firefox's Bookmarks Toolbar,
advertise URL support and convert the file to a file:// URL at the widget
level. This mirrors the Windows implementation (FindURLFromLocalFile).

The fix has two parts:

1. nsDragService.mm: Advertise URL support when files are present on the
   pasteboard by checking for kUTTypeFileURL when kURLMime is requested
2. nsCocoaUtils.mm: Convert files to file:// URLs when kURLMime is
   requested but only kUTTypeFileURL is available, formatting as
   "URL\nTitle" to match the expected text/x-moz-url format

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/d0b9c5b37f48
https://hg.mozilla.org/integration/autoland/rev/52d25a41275f
Enable dragging files to create bookmarks on macOS. r=spohl

Comment 6

[agoloman]

https://hg.mozilla.org/mozilla-central/rev/52d25a41275f