411452 - when a url bar search term is in both the place title and the bookmark title, show the bookmark title in the result

Status: VERIFIED FIXED

(Firefox :: Address Bar, defect)

Description

[(not reading, please use [e-mail] instead)]

when a url bar search term is in both the place title and the bookmark title, which should be shown?

with bug #394038, we now search both the title in moz_places and the title in moz_bookmarks (as well as the url).

say I bookmark http://espn.go.com/ (with the moz_place title of "ESPN: The Worldwide Leader in Sports") and make the bookmark title "espn"

when I type esp in the url bar, should my matching result be:

ESPN: The Worldwide Leader in Sports
http://espn.go.com/

or

espn
http://espn.go.com/

In the current patch for bug #394038, I'm currently doing the first, but perhaps the second is the correct behavior.  thoughts?

from the patch:

+      // XXX is it correct to prefer moz_place title over bookmark title?  if not, we need reorder our mDBAutoCompleteQuery and fix this code
+      PRBool matchInBookmarkTitle = PR_FALSE;
+      if (itemId && 
+          !CaseInsensitiveFindInReadable(mCurrentSearchString, entryTitle) && 
+          !CaseInsensitiveFindInReadable(mCurrentSearchString, entryURL)) {
+        matchInBookmarkTitle = PR_TRUE;
+        // XXX, if this is not debug only, wrap with an #ifdef DEBUG
+        NS_WARN_IF_FALSE(CaseInsensitiveFindInReadable(mCurrentSearchString, entryBookmarkTitle), "match should be in bookmark title");
+      }

note if you type "espn:", you'll get:

ESPN: The Worldwide Leader in Sports
http://espn.go.com/

Comment 1

[(not reading, please use [e-mail] instead)]

I think we want the latter, because the moz_place can change (as can the bookmark title, with microsummaries), but if the user puts in "espn" or whatever, they probably prefer that over the other.

Comment 2

[(not reading, please use [e-mail] instead)]

over email, both beltzner and faaborg agree.

sspitzer:

> (I think bookmark title over place title.)

faaborg:

> Yeah, I agree.

beltzner:

> I'm not entirely sure what a "place title" is; do you mean the page title? If > so, I agree this this proposal as well. 

This already part of the latest patch in #394038.

Comment 3

[Dietrich Ayala (:dietrich)]

fixed by bug 394038

Comment 4

[Mike Lierman]

*** VERIFIED

Mozilla/5.0 (Windows; U; Windows NT 6.0; en-US; rv:1.9b3) Gecko/2008020514 Firefox/3.0b3

Comment 5

[Stephen Donner [:stephend] Not actively reading bugmail]

in-litmus+

https://litmus.mozilla.org/show_test.cgi?id=5172

Also, verified FIXED using Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.4; en-US; rv:1.9b4pre) Gecko/2008020904 Minefield/3.0b4pre