Closed
Bug 411603
Opened 17 years ago
Closed 17 years ago
Infinite-recursion crash setting scriptminsize on <mstyle>
Categories
(Core :: MathML, defect)
Tracking
()
RESOLVED
FIXED
People
(Reporter: jruderman, Assigned: roc)
References
Details
(Keywords: crash, regression, testcase)
Attachments
(2 files)
|
239 bytes,
application/xhtml+xml
|
Details | |
|
1.71 KB,
patch
|
dbaron
:
review+
dbaron
:
superreview+
beltzner
:
approval1.9+
|
Details | Diff | Splinter Review |
Loading the testcase crashes Firefox. I'm guessing this is a regression, and that it's a regression from bug 355548.
|
Assignee | |
Updated•17 years ago
|
Assignee: nobody → roc
Flags: blocking1.9?
|
|
Assignee | |
Comment 1•17 years ago
|
||
Font-relative units for scriptminsize should be interpreted relative to the parent font, not the current font, obviously we get a nasty circular dependence otherwise.
Attachment #296289 -
Flags: superreview?(dbaron)
Attachment #296289 -
Flags: review?(dbaron)
|
|
Assignee | |
Comment 2•17 years ago
|
||
BTW Jesse, finding this bug about 12 hours after the patch was checked in is incredibly impressive.
Whiteboard: [needs review]
|
Reporter | |
Comment 3•17 years ago
|
||
> + // scriptminsize in font units (em, ex) has to be interpreted relative
> + // to the parent font, or the size definitions are circular and we
> + //
The suspense!
Whiteboard: [needs review]
Comment on attachment 296289 [details] [diff] [review]
fix
I think this needs to be fixed in the spec as well. Could you send a note to www-math? Or should I?
Attachment #296289 -
Flags: superreview?(dbaron)
Attachment #296289 -
Flags: superreview+
Attachment #296289 -
Flags: review?(dbaron)
Attachment #296289 -
Flags: review+
|
|
Assignee | |
Comment 5•17 years ago
|
||
|
|
Assignee | |
Comment 6•17 years ago
|
||
Comment on attachment 296289 [details] [diff] [review]
fix
fixes crash regression
Attachment #296289 -
Flags: approval1.9?
|
|
Reporter | |
Comment 7•17 years ago
|
||
http://www.w3.org/TR/2003/REC-MathML2-20031021/chapter2.html#id.2.4.4.2.1
"These units are relative to the font and font size which would be used for rendering the element in whose attribute value they are specified"
That's not quite the same thing as being relative to the parent's font size, and it doesn't sound circular to me.
Sounds circular to me, although "would be" without a condition is a bit confusing.
|
||
Comment 9•17 years ago
|
||
Comment on attachment 296289 [details] [diff] [review]
fix
a=beltzner for 1.9
Attachment #296289 -
Flags: approval1.9? → approval1.9+
|
|
Assignee | |
Comment 10•17 years ago
|
||
checked in
Status: NEW → RESOLVED
Closed: 17 years ago
Flags: blocking1.9? → in-testsuite+
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•