Closed Bug 411620 Opened 12 years ago Closed 12 years ago

Migrate SeaMonkey's tabbed browsing preferences to new pref window

Categories

(SeaMonkey :: Preferences, defect)

defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED
seamonkey2.0a1

People

(Reporter: stefanh, Assigned: stefanh)

References

Details

Attachments

(3 files)

I re-indented the file so -w version coming up... Not much to say, everything appears to work on Mac here - only thing was "inverted" instead of "reversed" :-)
Attachment #296288 - Flags: review?(neil)
Attached patch -w versionSplinter Review
So, I never checked Modern and it appears that the prefs pane is cut-off at the bottom...
Attachment #296288 - Attachment is obsolete: true
Attachment #296290 - Attachment is obsolete: true
Attachment #296288 - Flags: review?(neil)
Hmm, so this is a general issue.
I've just had a conversation with Ratty. Bug 390270 is to blame here - I don't think there shouldn't be any padding on prefpane and .prefWindow-dlgbuttons. Only the child elements should have padding. Also, the prefwindow looks like it should have a different padding in communicator/preferences.css. I'll file a new bug on this tomorrow.
Attachment #296288 - Attachment is obsolete: false
Attachment #296290 - Attachment is obsolete: false
Comment on attachment 296288 [details] [diff] [review]
Migrate the prefs

Filed bug 412167 regarding the padding issues.
Attachment #296288 - Flags: review?(neil)
Attachment #296288 - Flags: review?(neil) → review+
Checking in suite/common/pref/pref-tabs.xul;
/cvsroot/mozilla/suite/common/pref/pref-tabs.xul,v  <--  pref-tabs.xul
new revision: 1.14; previous revision: 1.13
done
Checking in suite/common/pref/preferences.xul;
/cvsroot/mozilla/suite/common/pref/preferences.xul,v  <--  preferences.xul
new revision: 1.8; previous revision: 1.7
done

(this one had to go in a separate check-in)
Checking in suite/common/pref/preftree.xul;
/cvsroot/mozilla/suite/common/pref/preftree.xul,v  <--  preftree.xul
new revision: 1.112; previous revision: 1.111
done
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.