Bug 407931 made some CSS too specific.

RESOLVED FIXED

Status

SeaMonkey
UI Design
--
minor
RESOLVED FIXED
10 years ago
10 years ago

People

(Reporter: Philip Chee, Assigned: Philip Chee)

Tracking

Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

(URL)

Attachments

(1 attachment, 1 obsolete attachment)

(Assignee)

Description

10 years ago
Created attachment 296306 [details] [diff] [review]
Restores the behaviour of the previous CSS.

In Bug 407931 which switched from "buttonstyle" to "mode" some of the CSS was made more specific than previously. Basically the styles in the patch that apply to the "toolbar-1" class should instead apply to all <button>s and <toolbarbutton>s instead. This patch restores the old behaviour (which also removes a contradictory style between toolbar.css and button.css).
Attachment #296306 - Flags: superreview?(neil)
Attachment #296306 - Flags: review?(stefanh)
(Assignee)

Comment 1

10 years ago
s/the styles/some styles/

stefan: I'll need you to help test this patch on OSX.
(Assignee)

Comment 2

10 years ago
Created attachment 296540 [details] [diff] [review]
Patch v 1.1 Change CSS rules to match the old buttonstyle styles [Simplified CSS]

As per discussion over #irc with stefanh and KaiRo. Simplified the CSS by reducing the number of selectors where possible.
Attachment #296306 - Attachment is obsolete: true
Attachment #296540 - Flags: review?(stefanh)
Attachment #296306 - Flags: superreview?(neil)
Attachment #296306 - Flags: review?(stefanh)

Comment 3

10 years ago
Comment on attachment 296540 [details] [diff] [review]
Patch v 1.1 Change CSS rules to match the old buttonstyle styles [Simplified CSS]

r=stefanh, without checking the windows part.
Attachment #296540 - Flags: review?(stefanh) → review+
(Assignee)

Comment 4

10 years ago
OK I'll test the windows part then.
(Assignee)

Comment 5

10 years ago
Comment on attachment 296540 [details] [diff] [review]
Patch v 1.1 Change CSS rules to match the old buttonstyle styles [Simplified CSS]

> OK I'll test the windows part then.

The simplified styles are working in classic. Tested in Navigator and in the main MailNews windows. The changes in modern are working as well except that in Navigator, the .toolbarbutton-menubutton-dropmarker styles are trumped by more specific styles in toolbar.css and navigator.css but this was also the case before the buttonstyle prefs were removed.
Attachment #296540 - Flags: superreview?(neil)

Comment 6

10 years ago
I think I remember why I wrote these styles like this; it was so that only toolbarbutton-1 toolbarbuttons got affected by the text/icons mode setting.

So, for instance, bookmark items wouldn't be affected.
(Assignee)

Comment 7

10 years ago
The button prefs (both the old style "buttonstyle" and the new style "mode") aren't applied to the Personal Toolbar[1] according to the DOM inspector so this patch doesn't regress the bookmark items in the personal toolbar. Anybody know why? I see the #grippytoolbar bindings attached though.

[1] All this will change if my customizable toolbars patch lands[2]
[2] Which is why that patch has a css section called Personal Toolbar over-rides.
(Assignee)

Updated

10 years ago
Blocks: 394288
(Assignee)

Updated

10 years ago
Status: NEW → ASSIGNED
(Assignee)

Updated

10 years ago
Assignee: nobody → philip.chee
Status: ASSIGNED → NEW

Updated

10 years ago
Attachment #296540 - Flags: superreview?(neil) → superreview+
(Assignee)

Updated

10 years ago
Keywords: checkin-needed
Checking in suite/themes/classic/communicator/mac/button.css;
/cvsroot/mozilla/suite/themes/classic/communicator/mac/button.css,v  <--  button.css
new revision: 1.17; previous revision: 1.16
done
Checking in suite/themes/classic/communicator/win/button.css;
/cvsroot/mozilla/suite/themes/classic/communicator/win/button.css,v  <--  button.css
new revision: 1.17; previous revision: 1.16
done
Checking in suite/themes/classic/navigator/navigator.css;
/cvsroot/mozilla/suite/themes/classic/navigator/navigator.css,v  <--  navigator.css
new revision: 1.43; previous revision: 1.42
done
Checking in suite/themes/modern/communicator/button.css;
/cvsroot/mozilla/suite/themes/modern/communicator/button.css,v  <--  button.css
new revision: 1.55; previous revision: 1.54
done
Status: NEW → RESOLVED
Last Resolved: 10 years ago
Keywords: checkin-needed
Resolution: --- → FIXED

Updated

10 years ago
Component: XP Apps: GUI Features → UI Design
You need to log in before you can comment on or make changes to this bug.