Update Polish Wikipedia search plugin to support suggestions

VERIFIED FIXED

Status

Mozilla Localizations
pl / Polish
VERIFIED FIXED
9 years ago
9 years ago

People

(Reporter: marcoos, Assigned: marcoos)

Tracking

({verified1.8.1.12})

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(2 attachments, 3 obsolete attachments)

The search plugin Wikipedia offers on wikipedia.org implements the MozSearch suggestions feature.

Let's update the Wikipedia plugin in the Polish localization of Firefox 3 to do the same.
(Assignee)

Comment 1

9 years ago
Created attachment 296381 [details] [diff] [review]
Add suggestions to Wikipedia's plugin
Attachment #296381 - Flags: review?(l10n)
(Assignee)

Comment 2

9 years ago
Created attachment 296384 [details] [diff] [review]
Add suggestions to Wikipedia's plugin

...but don't drop the sourceid=Mozilla part ;)
Attachment #296384 - Flags: review?(l10n)
(Assignee)

Updated

9 years ago
Attachment #296381 - Attachment is obsolete: true
Attachment #296381 - Flags: review?(l10n)
The OpenSearch namespace changes really aren't necessary, the search service ignores namespaces entirely.
(Assignee)

Comment 4

9 years ago
Ok, I'll drop the namespace. I just did what the official Wikipedia plugin does.
(Assignee)

Comment 5

9 years ago
Created attachment 296412 [details] [diff] [review]
Add suggestions to Wikipedia's plugin

Dropping the OpenSearch namespace, bringing back <SearchForm />.
Attachment #296384 - Attachment is obsolete: true
Attachment #296412 - Flags: review?(l10n)
Attachment #296384 - Flags: review?(l10n)
(Assignee)

Comment 6

9 years ago
Created attachment 296416 [details] [diff] [review]
Add suggestions to Wikipedia's plugin

Use <Param>s instead of query string full of HTML entities
Attachment #296416 - Flags: review?(l10n)
(Assignee)

Updated

9 years ago
Attachment #296416 - Attachment is patch: true
Attachment #296416 - Attachment mime type: application/octet-stream → text/plain
(Assignee)

Updated

9 years ago
Attachment #296412 - Attachment is obsolete: true
Attachment #296412 - Flags: review?(l10n)
Comment on attachment 296416 [details] [diff] [review]
Add suggestions to Wikipedia's plugin

r=me with two nits, see below

>Index: pl/browser/searchplugins/wikipedia-pl.xml
<...>
>+<Url type="text/html" method="GET" template="http://pl.wikipedia.org/w/index.php">
>+    <Param name="title" value="Specjalna:Szukaj" />

Make this template="http://pl.wikipedia.org/wiki/Specjalna:Szukaj"
and drop the title param.

>+    <Param name="search" value="{searchTerms}" />
>+    <Param name="sourceid" value="Mozilla-search" />
>+</Url>
<SearchForm>http://pl.wikipedia.org/wiki/Specjalna:Search</SearchForm>
> </SearchPlugin>
>\ No newline at end of file

Add a trailing newline, too?

Please check this in with a check-in comment referencing this bug and my review.
Attachment #296416 - Flags: review?(l10n) → review+
(Assignee)

Comment 8

9 years ago
Checking in wikipedia-pl.xml;
/l10n/l10n/pl/browser/searchplugins/wikipedia-pl.xml,v  <--  wikipedia-pl.xml
new revision: 1.3; previous revision: 1.2
done
Status: NEW → RESOLVED
Last Resolved: 9 years ago
Resolution: --- → FIXED
(Assignee)

Comment 9

9 years ago
Can I fix this also on the 1.8 branch for Firefox 2.0.0.x?
Comment on attachment 296416 [details] [diff] [review]
Add suggestions to Wikipedia's plugin

This patch also applies cleanly to the 1.8 branch.
Attachment #296416 - Flags: approval1.8.1.12?
Created attachment 296558 [details] [diff] [review]
Patch for the 1.8 branch

This is the patch as checked in to trunk (with all the stuff from comment 7 applied), ready for checking in to 1.8, if that gets approval.
Attachment #296558 - Flags: approval1.8.1.12?
(Assignee)

Updated

9 years ago
Attachment #296416 - Flags: approval1.8.1.12?
(Assignee)

Updated

9 years ago
Attachment #296558 - Attachment is patch: true
Attachment #296558 - Attachment mime type: application/octet-stream → text/plain
Comment on attachment 296558 [details] [diff] [review]
Patch for the 1.8 branch

[pl] approval for landing an update to the wikipedia search plugin on the branch.

Please use the fixed1.8.1.12 and verified.... keywords to track landing and testing.
Attachment #296558 - Flags: approval1.8.1.12? → approval1.8.1.12+
Checking in wikipedia-pl.xml;
/l10n/l10n/pl/browser/searchplugins/wikipedia-pl.xml,v  <--  wikipedia-pl.xml
new revision: 1.1.2.2; previous revision: 1.1.2.1
done
Keywords: fixed1.8.1.12

Comment 14

9 years ago
Verified (Fx 3.0 beta 3 & Fx 2.0.0.12)
Status: RESOLVED → VERIFIED
Keywords: fixed1.8.1.12 → verified1.8.1.12
You need to log in before you can comment on or make changes to this bug.