411735 - add client side validation to try server form

Status: RESOLVED WONTFIX

(Release Engineering :: General, defect, P5)

Description

[[e-mail] (:bhearsum)]

sdwilsh pointed out that the try server validation is a PITA if you have a huge patch. He also offered to write some client side validation into it.

Shawn, the code lives in http://lxr.mozilla.org/mozilla/source/webtools/buildbot-try. You'll need the $ALLOWED_* regexs from sendchange.cgi. Please move them to sendchange-ui.pm and import them back into sendchange.cgi.

Thank you very much for doing this!

Comment 1

[[e-mail] (:bhearsum)]

Hey Shawn, are you still planning to do this?

Comment 2

[Shawn Wilsher :sdwilsh]

Yup - Firefox blockers are a bit higher on the priority list at the moment though ;)

Feel free to take this if you think it's important enough.

Comment 3

[[e-mail] (:bhearsum)]

NP! Just checking :)

Comment 4

[[e-mail] (:bhearsum)]

Moving try server bugs to the new component.

Comment 5

[[e-mail] (:bhearsum)]

Hey Shawn, seems like you're too busy to do this right now. That's fine, I'm just going to reassign for now though.

Comment 6

[Shawn Wilsher :sdwilsh]

yeah, still got blockers :/

Once those are done I'll try to pick this back up.

Comment 7

[[e-mail] (:bhearsum)]

Mass change of target milestone.

Comment 8

[[e-mail] (:bhearsum)]

Validation of the 'patch' field was done in 437143. Should/could add validation to other fields as well, so I'll leave this bug open.

Comment 9

[Chris Cooper [:coop] (he/him)]

Mass move of bugs from Release Engineering:Future -> Release Engineering. See
http://coop.deadsquid.com/2010/02/kiss-the-future-goodbye/ for more details.

Comment 10

[Lukas Blakk [:lsblakk] use ?needinfo]

The hg commit message patches went in today. Next we will be extending that to be able to read from a committed config file too. 

At this time there is no try server web UI form, and based on all the work done above, its unclear if we will ever need to create one. If we do, then we can do the validation at the same time as creating the UI. However, at this time, this bug's request is unnecessary.