411847 - About box for customized distributions doesn't show distribution name

Status: RESOLVED FIXED

(Firefox :: General, defect)

Description

[Dan Mills [:thunder]]

The about box should show a short blurb about the distribution, but it currently does not work (maybe only works on Mac).

The reason: aboutDialog.js uses the 'Ci' shorthand in the code that adds the distribution info to the dialog.  I think on Mac it's available, but it's definitely not on Windows.

Patch coming up.

Comment 1

[Dan Mills [:thunder]]

Attachment: Fix about box to show distribution name and version (v1)

-p1 patch.

Comment 2

[:Gavin Sharp [email: [e-mail]]]

Oops, looks like we we forgot this one case in bug 395862 :(.

Comment 3

[Dan Mills [:thunder]]

Checking in aboutDialog.js;
/cvsroot/mozilla/browser/base/content/aboutDialog.js,v  <--  aboutDialog.js
new revision: 1.11; previous revision: 1.10
done

Comment 4

[Dan Mills [:thunder]]

Sadly, there is a typo in my patch.  Reopening :-(

Comment 5

[Dan Mills [:thunder]]

Attachment: Fix typo in previous patch

Component -> Components

Comment 6

[Dan Mills [:thunder]]

Comment on attachment 300695 [details] [diff] [review]
Fix typo in previous patch

This is super-low-risk.  Requesting approval for b3.

Comment 7

[Mike Beltzner [:beltzner, not reading bugmail]]

Comment on attachment 300695 [details] [diff] [review]
Fix typo in previous patch

a=beltzner, +s!

Comment 8

[Dan Mills [:thunder]]

Thanks Beltzner.  Landed:

Checking in aboutDialog.js;
/cvsroot/mozilla/browser/base/content/aboutDialog.js,v  <--  aboutDialog.js
new revision: 1.12; previous revision: 1.11
done