Closed Bug 411847 Opened 14 years ago Closed 14 years ago

About box for customized distributions doesn't show distribution name

Categories

(Firefox :: General, defect)

x86
All
defect
Not set
normal

Tracking

()

RESOLVED FIXED

People

(Reporter: hello, Assigned: hello)

Details

Attachments

(2 files)

The about box should show a short blurb about the distribution, but it currently does not work (maybe only works on Mac).

The reason: aboutDialog.js uses the 'Ci' shorthand in the code that adds the distribution info to the dialog.  I think on Mac it's available, but it's definitely not on Windows.

Patch coming up.
Flags: blocking-firefox3?
-p1 patch.
Attachment #296480 - Flags: review?(mano)
Oops, looks like we we forgot this one case in bug 395862 :(.
Attachment #296480 - Flags: approval1.9?
Attachment #296480 - Flags: approval1.9? → approval1.9+
Checking in aboutDialog.js;
/cvsroot/mozilla/browser/base/content/aboutDialog.js,v  <--  aboutDialog.js
new revision: 1.11; previous revision: 1.10
done
Status: NEW → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
Sadly, there is a typo in my patch.  Reopening :-(
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Component -> Components
Comment on attachment 300695 [details] [diff] [review]
Fix typo in previous patch

This is super-low-risk.  Requesting approval for b3.
Attachment #300695 - Flags: approval1.9b3?
Comment on attachment 300695 [details] [diff] [review]
Fix typo in previous patch

a=beltzner, +s!
Attachment #300695 - Flags: approval1.9b3? → approval1.9b3+
Thanks Beltzner.  Landed:

Checking in aboutDialog.js;
/cvsroot/mozilla/browser/base/content/aboutDialog.js,v  <--  aboutDialog.js
new revision: 1.12; previous revision: 1.11
done
Status: REOPENED → RESOLVED
Closed: 14 years ago14 years ago
Resolution: --- → FIXED
Flags: blocking-firefox3?
You need to log in before you can comment on or make changes to this bug.