directory list should use localized ellipsis

VERIFIED FIXED

Status

()

Core
Internationalization
--
minor
VERIFIED FIXED
10 years ago
10 years ago

People

(Reporter: Masahiro YAMADA, Assigned: Masahiro YAMADA)

Tracking

Trunk
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

3.90 KB, patch
Masahiro YAMADA
: review+
beltzner
: approval1.9+
Details | Diff | Splinter Review
(Assignee)

Description

10 years ago
User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9b3pre) Gecko/2008011005 Minefield/3.0b3pre
Build Identifier: 

spun off from Bug 403484 Comment 47.

See
http://bonsai.mozilla.org/cvsblame.cgi?file=/mozilla/netwerk/streamconv/converters/nsIndexedToHTML.cpp&rev=1.88#828

It uses "…" and it is hard coded.
I think it should be replaced as HTML escaped localized ellipsis.


Reproducible: Always

Steps to Reproduce:
1.Change intl.ellipsis in about:config.
2.Show directory list that contains file that has very long name.
3.
Actual Results:  
Ellipsis is always U+2026.

Expected Results:  
Ellipsis should be loczlized.

Simple proposal:
-    escapedShort.AppendLiteral("…");
+    AppendNonAsciiToNCR(nsContentUtils::GetLocalizedEllipsis(), escapedShort);

# It may be needed to add including nsContentUtils.h
(Assignee)

Updated

10 years ago
Version: unspecified → Trunk

Updated

10 years ago
Depends on: 403484

Updated

10 years ago
Assignee: nobody → smontagu
Severity: trivial → minor
Status: UNCONFIRMED → NEW
Component: File Handling → Internationalization
Ever confirmed: true
QA Contact: file-handling → i18n

Comment 1

10 years ago
Masahiro, would you be willing to take this bug and provide a real patch ?

(reassign to yourself if so)
(Assignee)

Comment 2

10 years ago
(In reply to comment #1)
> Masahiro, would you be willing to take this bug and provide a real patch ?
> 
> (reassign to yourself if so)
> 
I'll write patch.
But I found other bugs for same source file.
I think one of them are more important.
Patch for this bug conflicts to it.
(Assignee)

Comment 3

10 years ago
I thought I can use nsContentUtils::GetLocalizedEllipsis() to get intl.ellipsis.

But, [#include "nsContentUtils.h"] causes failure of compile.
(complier failed to find 'nsContentUtils.h').

Which is better to modify makefile or to implement without nsContentUtils::GetLocalizedEllipsis() ?
(Assignee)

Comment 4

10 years ago
Created attachment 300848 [details] [diff] [review]
Patch rv.1.0

Whom souhld I request review ?
And is it needed superreview and ui-review ?
Attachment #300848 - Flags: review?
(Assignee)

Updated

10 years ago
Attachment #300848 - Flags: review? → review?(mano)
Yamada-san:

FYI: you can find the reviewers for each modules from CVS log of LXR.
Comment on attachment 300848 [details] [diff] [review]
Patch rv.1.0

I'm not a necko peer
Attachment #300848 - Flags: review?(mano)
(Assignee)

Updated

10 years ago
Attachment #300848 - Flags: review?(bzbarsky)
Comment on attachment 300848 [details] [diff] [review]
Patch rv.1.0

Make that mEscapedEllipsis, and looks ok.  Thank you for fixing this!
Attachment #300848 - Flags: review?(bzbarsky) → review+

Comment 8

10 years ago
What are we waiting for here?
(Assignee)

Comment 9

10 years ago
Is superreview and ui-review needed for attachment 300348 [details] ?
(Assignee)

Comment 10

10 years ago
(In reply to comment #9)
> Is superreview and ui-review needed for attachment 300348 [details] ?
> 
Oops, it's attachment 300848 [details] [diff] [review].

No ui-review needed. Boris does superreviews, and he usually does it along with the review, so I guess it's kind of redundant.
(In reply to comment #7)
> (From update of attachment 300848 [details] [diff] [review])
> Make that mEscapedEllipsis

Masahiro, can you please make that change, attach a new patch and request approval1.9?

Updated

10 years ago
Assignee: smontagu → masa141421356
(Assignee)

Comment 13

10 years ago
Created attachment 314547 [details] [diff] [review]
Patch rev.1.1

renamed escapedEllipsis to mEscapedEllipsis
Attachment #300848 - Attachment is obsolete: true
Attachment #314547 - Flags: review+
Attachment #314547 - Flags: approval1.9?
Comment on attachment 314547 [details] [diff] [review]
Patch rev.1.1

a1.9=beltzner
Attachment #314547 - Flags: approval1.9? → approval1.9+

Updated

10 years ago
Keywords: checkin-needed
checked-in, thank you for your work!
Status: NEW → RESOLVED
Last Resolved: 10 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
(Assignee)

Comment 16

10 years ago
verified at
Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9pre) Gecko/2008041005 Minefield/3.0pre
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.