411854 - directory list should use localized ellipsis

Status: VERIFIED FIXED

(Core :: Internationalization, defect)

Description

[Masahiro YAMADA]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9b3pre) Gecko/2008011005 Minefield/3.0b3pre
Build Identifier: 

spun off from Bug 403484 Comment 47.

See
http://bonsai.mozilla.org/cvsblame.cgi?file=/mozilla/netwerk/streamconv/converters/nsIndexedToHTML.cpp&rev=1.88#828

It uses "…" and it is hard coded.
I think it should be replaced as HTML escaped localized ellipsis.


Reproducible: Always

Steps to Reproduce:
1.Change intl.ellipsis in about:config.
2.Show directory list that contains file that has very long name.
3.
Actual Results:  
Ellipsis is always U+2026.

Expected Results:  
Ellipsis should be loczlized.

Simple proposal:
-    escapedShort.AppendLiteral("…");
+    AppendNonAsciiToNCR(nsContentUtils::GetLocalizedEllipsis(), escapedShort);

# It may be needed to add including nsContentUtils.h

Comment 1

[Jean-Marc Desperrier]

Masahiro, would you be willing to take this bug and provide a real patch ?

(reassign to yourself if so)

Comment 2

[Masahiro YAMADA]

(In reply to comment #1)
> Masahiro, would you be willing to take this bug and provide a real patch ?
> 
> (reassign to yourself if so)
> 
I'll write patch.
But I found other bugs for same source file.
I think one of them are more important.
Patch for this bug conflicts to it.

Comment 3

[Masahiro YAMADA]

I thought I can use nsContentUtils::GetLocalizedEllipsis() to get intl.ellipsis.

But, [#include "nsContentUtils.h"] causes failure of compile.
(complier failed to find 'nsContentUtils.h').

Which is better to modify makefile or to implement without nsContentUtils::GetLocalizedEllipsis() ?

Comment 4

[Masahiro YAMADA]

Attachment: Patch rv.1.0

Whom souhld I request review ?
And is it needed superreview and ui-review ?

Comment 5

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Yamada-san:

FYI: you can find the reviewers for each modules from CVS log of LXR.

Comment 6

[Asaf Romano (gone)]

Comment on attachment 300848 [details] [diff] [review]
Patch rv.1.0

I'm not a necko peer

Comment 7

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 300848 [details] [diff] [review]
Patch rv.1.0

Make that mEscapedEllipsis, and looks ok.  Thank you for fixing this!

Comment 8

[Dão Gottwald [:dao]]

What are we waiting for here?

Comment 9

[Masahiro YAMADA]

Is superreview and ui-review needed for attachment 300348 [details] ?

Comment 10

[Masahiro YAMADA]

(In reply to comment #9)
> Is superreview and ui-review needed for attachment 300348 [details] ?
> 
Oops, it's attachment 300848 [details] [diff] [review].

Comment 11

[Dão Gottwald [:dao]]

No ui-review needed. Boris does superreviews, and he usually does it along with the review, so I guess it's kind of redundant.

Comment 12

[Dão Gottwald [:dao]]

(In reply to comment #7)
> (From update of attachment 300848 [details] [diff] [review])
> Make that mEscapedEllipsis

Masahiro, can you please make that change, attach a new patch and request approval1.9?

Comment 13

[Masahiro YAMADA]

Attachment: Patch rev.1.1

renamed escapedEllipsis to mEscapedEllipsis

Comment 14

[Mike Beltzner [:beltzner, not reading bugmail]]

Comment on attachment 314547 [details] [diff] [review]
Patch rev.1.1

a1.9=beltzner

Comment 15

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

checked-in, thank you for your work!

Comment 16

[Masahiro YAMADA]

verified at
Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9pre) Gecko/2008041005 Minefield/3.0pre