411952 - Cookie's creationTime needs to be exposed via nsICookie2

Status: RESOLVED FIXED

(Core :: Networking: Cookies, defect)

Description

[(no longer active)]

Spinoff from bug 248970 comment 45.

The creationTime field of the cookies' DB should be exposed from the nsICookie2 interface.  Throwing this off to Dan, as he volunteered for it.  :-)

Thanks, Dan!

Comment 1

[(no longer active)]

Dan: do you think you would be able to submit a patch in the next couple of days?  If not, would you mind giving a few pointers so that I can come up with a patch myself?  I'll need this in bug 248970...

Comment 2

[(no longer active)]

Based on bug 248970 comment 70, this should no longer be a blocker for that bug...

Comment 3

[(no longer active)]

Attachment: Patch

The patch includes a unit test, which allows the creationTime  attribute to slip by 1 second maximum, to skip timing issues when running the test.

Comment 4

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 339573 [details] [diff] [review]
Patch

Should perhaps be |long long| in the IDL.

Comment 5

[(no longer active)]

(In reply to comment #4)
> (From update of attachment 339573 [details] [diff] [review])
> Should perhaps be |long long| in the IDL.

I noted that the expiry attribute was declared as PRInt64, so I thought creationTime should be as well...

Comment 6

[(no longer active)]

bz: ping?

Comment 7

[Boris Zbarsky [:bzbarsky]]

Ah, yeah, keeping those consistent is a good idea.  In the end it really doesn't matter much: the two get folded to the same thing by everyone.

Comment 8

[(no longer active)]

bz: thanks for your comments!

Actually, I thought this patch has dwitte's r+ and is awaiting your sr... :/

So, I guess what I really meant was:

dwitte: ping?

:-)

Comment 9

[(no longer active)]

Comment on attachment 339573 [details] [diff] [review]
Patch

Throwing this to mconnor...

Comment 10

[Mike Connor [:mconnor]]

Comment on attachment 339573 [details] [diff] [review]
Patch

r=mconnor, because dwitte seems to have wandered away somewhere.

Comment 11

[(no longer active)]

Pushed to mozilla-central: <http://hg.mozilla.org/mozilla-central/rev/4c45de526782>

Comment 12

[(no longer active)]

Err, I forget to hg addremove *all the time*!

<http://hg.mozilla.org/mozilla-central/rev/75036e89468d>

Comment 13

[Shawn Wilsher :sdwilsh]

So, the idl for this says it is in seconds, but the patch clearly calls CreationID, which returns microseconds.  The idl needs to be corrected (or the code does).

Comment 14

[[e-mail]]

fix the idl comment, please.

Comment 15

[Shawn Wilsher :sdwilsh]

And please add dev-doc needed and update https://developer.mozilla.org/en/Firefox_3.1_for_developers#For_XUL_and_application_developers when you do fix it.

Comment 16

[(no longer active)]

IDL comment fixed.  Thanks for catching this, Shawn!

<http://hg.mozilla.org/mozilla-central/rev/47dd67ed93a4>

Comment 17

[(no longer active)]

OK, I went ahead and documented this: <https://developer.mozilla.org/en/nsICookie2>

The documentation was mistakenly telling that nsICookie2 is frozen, and I corrected it as well.

Also, added a note on <https://developer.mozilla.org/en/Firefox_3.1_for_developers#For_XUL_and_application_developers>