Closed
Bug 411958
Opened 16 years ago
Closed 16 years ago
Use tinderboxen to build gdata-provider nightlies
Categories
(Calendar :: Build Config, defect)
Calendar
Build Config
Tracking
(Not tracked)
VERIFIED
FIXED
0.9
People
(Reporter: Fallen, Assigned: Fallen)
References
Details
(Whiteboard: [gdata-0.4])
Attachments
(3 files)
5.24 KB,
patch
|
ause
:
review+
|
Details | Diff | Splinter Review |
5.38 KB,
patch
|
Details | Diff | Splinter Review | |
6.42 KB,
patch
|
ause
:
review+
|
Details | Diff | Splinter Review |
Thanks to bug 410922, it is now possible to build the gdata provider and upload it as an extension to ftp.mozilla.org. It is sufficient to let one tinderbox build the gdata provider, it might look strange if only one tinderbox creates this xpi. Depending on how latest-mozilla1.8 is linked, we might want to go ahead an let all tinderboxen build the xpi.
Assignee | ||
Comment 1•16 years ago
|
||
Enable build for gdata. For now I just picked the sunbird linux tinderbox to build gdata. I would land the Makefile and install.rdf on both branches, test the nightly creation on one tinderbox and see if it uploads to the correct location. The way it is with this patch, I believe it will land in: ftp://ftp.mozilla.org/pub/calendar/sunbird/nightly/latest-mozilla1.8/xpi Is this path ok? Setting up a second tinderbox with the same configs might overwrite the same xpi file, so probably only one is needed. The same change could be done on a trunk tinderbox, then it will also be in latest-trunk/xpi. Thinking about alternatives, I don't think I can land it in pub/calendar/xpi so easily.
Attachment #297403 -
Flags: review?(ause)
Comment 2•16 years ago
|
||
Comment on attachment 297403 [details] [diff] [review] Enable building and uploading gdata >+++ calendar/providers/gdata/install.rdf 16 Jan 2008 20:22:16 -0000 ><!-- Thunderbird --> ><em:id>{3550f703-e582-4d05-9a08-453d09bdfdc6}</em:id> ><em:minVersion>2.0a1</em:minVersion> ><em:maxVersion>3.0a1</em:maxVersion> I think the extension should only install in Thunderbird as supported by the required Lightning version to avoid confusion. For example the gdata extension build that requires 0.8pre should only install in Thunderbird 2.0.0.0 to 2.0.0.*.
Assignee | ||
Comment 3•16 years ago
|
||
I didn't think of thunderbird versioning, but I think we are fine (for now). In case we don't check out a mail tree we won't have the version numbers. Also, I believe the gdata provider also runs on thunderbird trunk without problems. The knockout criterium on thunderbird trunk will be that the <em:requires> will require 0.8pre, which will not run on tb trunk.
Is this sufficient, or should I do the following:
>#ifdef MOZILLA_1_8_BRANCH
><em:minVersion>2.0a1</em:minVersion>
><em:maxVersion>2.0.0.*</em:maxVersion>
>#else
><em:minVersion>3.0a1</em:minVersion>
><em:maxVersion>3.0.0.*</em:maxVersion>
>#endif
Assignee | ||
Comment 5•16 years ago
|
||
ause, do you mind reviewing this soon, so I can more easily create nightlies?
Comment on attachment 297403 [details] [diff] [review] Enable building and uploading gdata activation in all lightning tb looks best to me
Attachment #297403 -
Flags: review?(ause) → review+
Assignee | ||
Comment 7•16 years ago
|
||
I want to check this in tomorrow. Daniel, is that ok with you also for SUNBIRD_0_8_BRANCH ?
Flags: wanted-calendar0.8?
Comment 8•16 years ago
|
||
Comment on attachment 297403 [details] [diff] [review] Enable building and uploading gdata >+DIRS = base \ >+ caldav \ >+ composite \ >+ gdata \ >+ ics \ >+ memory \ >+ storage \ >+ wcap \ Please add $(NULL).
Assignee | ||
Comment 10•16 years ago
|
||
Fixed $(NULL). These are the tinderbox configs I'm checking in, for lightning.
Assignee | ||
Comment 11•16 years ago
|
||
Gdata files checked in on HEAD and MOZILLA_1_8_BRANCH and SUNBIRD_0_8_BRANCH. tinderbox changes win/linux/mac checked in on HEAD and MOZILLA_1_8_BRANCH tinderbox changes solaris-* checked in on MOZILLA_1_8_BRANCH -> FIXED
Status: ASSIGNED → RESOLVED
Closed: 16 years ago
Resolution: --- → FIXED
Whiteboard: [gdata-cvs]
Target Milestone: --- → 0.8
Assignee | ||
Comment 12•16 years ago
|
||
Not working for mac: The tinderbox is looking for the gdata xpi from the lightning-obj/ppc/dist/universal/xpi-stage/ directory, but gdata is in the non-universal directory.
Comment 13•16 years ago
|
||
Seems the correct Thunderbird Trunk / 1.8 Branch support mentioned in Comment #2 and Comment #3 is missing from the checkin?
Comment 14•16 years ago
|
||
for mac problem see mac mozconfig of lightning tb and calendar/lightning/build/universal.mk
Flags: wanted-calendar0.8+ → wanted-calendar0.8?
Target Milestone: 0.8 → ---
Updated•16 years ago
|
Flags: wanted-calendar0.8?
Assignee | ||
Comment 15•16 years ago
|
||
(In reply to comment #13) > Seems the correct Thunderbird Trunk / 1.8 Branch support mentioned in Comment > #2 and Comment #3 is missing from the checkin? > Since I had no reply regarding my question there, I decided to leave it out. Reopening to fix the mac issue, and since I don't really mind, I'll also put in the trunk version change.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Assignee | ||
Comment 16•16 years ago
|
||
Untested, but something like this should fix it. ause, it would be great if you could give this patch a test on a working build mac.
Attachment #313156 -
Flags: review?(ause)
Comment 17•16 years ago
|
||
daniel promised to do the testing.
Comment 18•16 years ago
|
||
my universal build has both xpis: /Users/dbo/moz18/sbird-uni-opt-Darwin/ppc/dist/universal/xpi-stage: total used in directory 2472 available 16459660 drwxr-xr-x 5 dbo staff 170 Apr 3 18:22 . drwxr-xr-x 4 dbo staff 136 Apr 3 17:40 .. -rw-r--r-- 1 dbo staff 44847 Apr 3 18:22 gdata-provider.xpi drwxr-xr-x 9 dbo staff 306 Apr 3 18:22 lightning -rw-r--r-- 1 dbo staff 1219854 Apr 3 18:22 lightning.xpi
Attachment #313156 -
Flags: review?(ause) → review+
Assignee | ||
Updated•16 years ago
|
Whiteboard: [gdata-cvs] → [gdata-0.4]
Assignee | ||
Comment 19•16 years ago
|
||
Checked in on HEAD and MOZILLA_1_8_BRANCH -> FIXED
Status: REOPENED → RESOLVED
Closed: 16 years ago → 16 years ago
Resolution: --- → FIXED
Target Milestone: --- → 0.9
Updated•16 years ago
|
Status: RESOLVED → VERIFIED
You need to log in
before you can comment on or make changes to this bug.
Description
•