411990 - [10.5] Tabbing through the bookmarks view should hit each column and enable editing (ExtendedOutlineView)

Status: RESOLVED INCOMPLETE

(Camino Graveyard :: Bookmarks, defect)

Description

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

On 10.5, tabbing through Safari's bookmarks treats each column (of the currently-highlighted row) as a tab-able destination and, like in table views, treats the first tab press as "start editing" and the second as "tab to the next column or control."  We should probably do this as well (see ExtendedTableView in bug 411599--but unlike that bug, this one does not cause the tab chain to die).

[5:56pm] murph: the only code I touched in the bookmark manager is the collections table view, as the actual bookmarks are in an outline view...
[5:57pm] murph: so we may have to look at ExtendedOutlineView too

Comment 1

[Sean Murphy]

The reason it's not working this time is because we actually mark ExtendedOutlineView's table columns as un-editable; instead we override -mouseDown: and then manually call editColumn:row:withEvent:select: to control inline editing.

To allow the proper tabbing behavior, the cells in the outline view must be editable.  I'm going to look into why we were doing this in the first place.  I'm hoping it was to support some functionality lacking on 10.2.  If we needed some more fine grained control over when editing started, we can probably accomplish that using some delegate method instead.

Comment 2

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

hendy was also going to look at our Extended* overrides, with a view to seeing what's still relevant and what's no longer needed.