Closed
Bug 412000
Opened 18 years ago
Closed 16 years ago
update verify should verify partial-update is smaller than/same size as complete-update
Categories
(Release Engineering :: General, defect, P5)
Release Engineering
General
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: joduinn, Assigned: salbiz)
References
Details
(Whiteboard: [simple][updates])
Attachments
(1 file)
|
1.78 KB,
patch
|
rail
:
review+
catlee
:
checked-in+
|
Details | Diff | Splinter Review |
The size of a partial update varies with each release, depending on the amount of changes present. However, by design, the size of a partial update is always smaller than, or equal to, the size of a complete update. If a partial update is bigger than a complete update, something is wrong.
We hit this during FF3.0beta2, and happened to manually notice it. Further debugging revealed a showstopper problem with the partial updates, so we had to regenerate the partial updates. We need to automate this sanity-check.
| Reporter | ||
Updated•18 years ago
|
Priority: -- → P3
| Reporter | ||
Updated•18 years ago
|
Component: Release Engineering → Release Engineering: Future
QA Contact: build → release
Comment 1•17 years ago
|
||
Adjusting the summary to reflect the major update case where partial == complete.
Summary: update verify should verify partial-update is smaller than complete-update → update verify should verify partial-update is smaller than/same size as complete-update
Comment 2•16 years ago
|
||
Mass move of bugs from Release Engineering:Future -> Release Engineering. See
http://coop.deadsquid.com/2010/02/kiss-the-future-goodbye/ for more details.
Component: Release Engineering: Future → Release Engineering
Updated•16 years ago
|
Whiteboard: [simple]
Updated•16 years ago
|
Priority: P3 → P5
Updated•16 years ago
|
Whiteboard: [simple] → [simple][updates]
Updated•16 years ago
|
Assignee: nobody → jhford
| Assignee | ||
Comment 3•16 years ago
|
||
put together a patch and tested on staging. Works, although I'm not sure that dumping the mar sizes into files is the cleanest way to go.
| Assignee | ||
Updated•16 years ago
|
Attachment #481023 -
Flags: review?(rail)
Comment 4•16 years ago
|
||
Comment on attachment 481023 [details] [diff] [review]
[tested]compare_update_sizes
Looks fine. Dumping the size to a file is not so bad, imo, especially for manual investigations.
Attachment #481023 -
Flags: review?(rail) → review+
Comment 6•16 years ago
|
||
Comment on attachment 481023 [details] [diff] [review]
[tested]compare_update_sizes
changeset: 912:096ea53af409
Attachment #481023 -
Flags: checked-in+
| Assignee | ||
Updated•16 years ago
|
Status: NEW → RESOLVED
Closed: 16 years ago
Resolution: --- → FIXED
Updated•13 years ago
|
Product: mozilla.org → Release Engineering
You need to log in
before you can comment on or make changes to this bug.
Description
•