Closed Bug 412025 Opened 17 years ago Closed 17 years ago

Need to add JSON xpt file to packages-static

Categories

(Core :: DOM: Core & HTML, defect, P1)

Product:
Core
Component:
DOM: Core & HTML
Type:
defect

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla1.9beta3

People

(Reporter: Gavin, Assigned: Gavin)

Details

Attachments

(3 files)

browser & mail patch (checked in)
2.79 KB, patch
sayrer
: review+
mscott
: review+
mtschrep
: approval1.9+
Details | Diff | Splinter Review
calendar patch (checked in)
947 bytes, patch
Fallen
: review+
Details | Diff | Splinter Review
seamonkey patch (checked in)
1.79 KB, patch
kairo
: review+
neil
: superreview+
Details | Diff | Splinter Review 
...otherwise JSON won't work in shipped builds.
I've tested this on Windows using the testcase in bug 410005 comment 1.
Assignee: nobody → gavin.sharp
Status: NEW → ASSIGNED
Attachment #296638 - Flags: review?(sayrer)
Attachment #296638 - Flags: review?(mscott)
Flags: blocking1.9?
Comment on attachment 296638 [details] [diff] [review]
browser & mail patch (checked in)

sr=mscott for the mail changes
Attachment #296638 - Flags: review?(mscott) → review+
Attachment #296638 - Attachment description: patch → browser & mail patch
I can land this on the trunk and 1.8 branch.
Attachment #296654 - Flags: review?(daniel.boelzle)
I'm not sure whether Camino requires similar package changes.
Priority: -- → P1
Target Milestone: --- → mozilla1.9 M11
Attachment #296638 - Flags: review?(sayrer) → review+
Attachment #296638 - Flags: approval1.9?
Yes, we'd need a project change to ship a new xpt. I can make that patch, but I'm guessing that libjson_s.a is new from whatever is requiring this change, and that we also need to link that?

Is there a test for this?

        Attachment #296676 -
        Flags: superreview?(neil)

        Attachment #296676 -
        Flags: review?(kairo)

    
    

    
  
(In reply to comment #5)
> Is there a test for this?

Not sure what you mean by a test, beyond bug 410005 comment 1 ... I don't think this code exposes anything to web content, yet.

    
    

    
  
Comment on attachment 296676 [details] [diff] [review]
seamonkey patch (checked in)

Looks good, thanks for thinking of SeaMonkey :) r=me

        Attachment #296676 -
        Flags: review?(kairo) → review+

    
  

        Attachment #296676 -
        Flags: superreview?(neil) → superreview+

    
  

        Attachment #296638 -
        Flags: approval1.9? → approval1.9+

    
    

    
  
Comment on attachment 296676 [details] [diff] [review]
seamonkey patch (checked in)

mozilla/suite/installer/unix/packages 	1.6
mozilla/suite/installer/windows/packages 	1.42

        Attachment #296676 -
        Attachment description: seamonkey patch → seamonkey patch (checked in)

    
    

    
  
Comment on attachment 296638 [details] [diff] [review]
browser & mail patch (checked in)

mozilla/browser/installer/unix/packages-static 	1.138
mozilla/browser/installer/windows/packages-static 	1.144
mozilla/mail/installer/windows/packages-static 	1.78

        Attachment #296638 -
        Attachment description: browser & mail patch → browser & mail patch (checked in)

    
    

    
  
Comment on attachment 296654 [details] [diff] [review]
calendar patch (checked in)

r=philipp

        Attachment #296654 -
        Flags: review?(daniel.boelzle) → review+

    
    

    
  
Comment on attachment 296654 [details] [diff] [review]
calendar patch (checked in)

mozilla/calendar/installer/windows/packages-static 	1.58
mozilla/calendar/installer/windows/packages-static 	1.10.2.41

        Attachment #296654 -
        Attachment description: calendar patch → calendar patch (checked in)
Status: ASSIGNED → RESOLVED
Closed: 17 years ago
Resolution: --- → FIXED

    
    

    
  
I filed bug 412126 for Camino.
Flags: blocking1.9?
Component: DOM → DOM: Core & HTML

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: