412237 - "ASSERTION: scriptminsize should never be making things bigger" with <ms fontsize="-2%">

Status: RESOLVED FIXED

(Core :: MathML, defect, P4)

Description

[Jesse Ruderman]

###!!! ASSERTION: scriptminsize should never be making things bigger: 'aFont->mScriptUnconstrainedSize <= aFont->mSize', file /Users/jruderman/trunk/mozilla/layout/style/nsRuleNode.cpp, line 2397

Comment 1

[Jesse Ruderman]

Attachment: testcase

Comment 2

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Attachment: fix

Trivial fix. We shouldn't parse negative values here.

Comment 3

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Comment on attachment 297683 [details] [diff] [review]
fix

r+sr=dbaron

Comment 4

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Checked in with test

Comment 5

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Amazingly this patched regressed reftest 355548-3.xml, so I backed it out. I'll try again after beta3.

Comment 6

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Attachment: updated fix

The regression was because we started refusing to parse "-0px". We should parse that as 0, IMHO, so this patch does that.

Comment 7

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Comment on attachment 300460 [details] [diff] [review]
updated fix

r+sr=dbaron

Comment 8

[Robert O'Callahan (:roc) (email my personal email if necessary)]

relanded