Closed
Bug 412246
Opened 18 years ago
Closed 18 years ago
Control-A/Select-All for userlist
Categories
(Other Applications Graveyard :: ChatZilla, enhancement)
Other Applications Graveyard
ChatZilla
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: Mitch, Assigned: rginda)
Details
(Whiteboard: [cz-0.9.81])
Attachments
(1 file, 2 obsolete files)
|
1.05 KB,
patch
|
Mitch
:
review+
|
Details | Diff | Splinter Review |
User-Agent: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-GB; rv:1.8.1.11) Gecko/20071127 Firefox/2.0.0.11
Build Identifier: ChatZilla 0.9.80
Both the "Select All" item in the Edit menu and Control-A don't select all users when the userlist is selected.
Reproducible: Always
Steps to Reproduce:
1. Click the userlist.
2. Press Control-A.
Actual Results:
Nothing happened.
Expected Results:
All users should have been selected.
|
Reporter | |
Comment 1•18 years ago
|
||
This adds "Select All" support for the userlist.
|
||
Updated•18 years ago
|
Severity: normal → enhancement
Status: UNCONFIRMED → NEW
Ever confirmed: true
OS: Windows XP → All
Hardware: PC → All
Version: unspecified → Trunk
|
|
||
Comment 2•18 years ago
|
||
Comment on attachment 296927 [details] [diff] [review]
Patch v1.0
I don't think there are a lot of cases to be made for this patch, but I don't have a problem with it as-is. Looks good, assuming you tested this works.
Attachment #296927 -
Flags: review+
|
|
||
Comment 3•18 years ago
|
||
Comment on attachment 296927 [details] [diff] [review]
Patch v1.0
Actually... you will need to check if userList.view (and possibly userList.view.selection) aren't null - they will be on non-channel views.
Attachment #296927 -
Flags: review+ → review-
|
|
Reporter | |
Comment 4•18 years ago
|
||
Updated patch.
Attachment #296927 -
Attachment is obsolete: true
Attachment #297475 -
Flags: review?(gijskruitbosch+bugs)
|
|
||
Comment 5•18 years ago
|
||
Comment on attachment 297475 [details] [diff] [review]
Patch v1.1
This looks good, r=me
Attachment #297475 -
Flags: review?(gijskruitbosch+bugs) → review+
|
|
Reporter | |
Comment 6•18 years ago
|
||
The last patch has an error; userlist should be userList.
Attachment #297475 -
Attachment is obsolete: true
Attachment #297668 -
Flags: superreview?(silver)
Attachment #297668 -
Flags: review?(gijskruitbosch+bugs)
|
|
Reporter | |
Comment 7•18 years ago
|
||
Comment on attachment 297668 [details] [diff] [review]
Patch v1.2
Gijs already granted the previous patch r+, and the latest patch only fixes a typo, so I gave it r+.
Attachment #297668 -
Flags: superreview?(silver)
Attachment #297668 -
Flags: review?(gijskruitbosch+bugs)
Attachment #297668 -
Flags: review+
|
|
||
Comment 8•18 years ago
|
||
Checking in mozilla/extensions/irc/xul/content/commands.js;
/cvsroot/mozilla/extensions/irc/xul/content/commands.js,v <-- commands.js
new revision: 1.141; previous revision: 1.140
done
Status: NEW → RESOLVED
Closed: 18 years ago
Resolution: --- → FIXED
Whiteboard: [cz-0.9.81]
|
||
Updated•10 months ago
|
Product: Other Applications → Other Applications Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•