412307 - Remove unneeded declarations from gnomestripe

Status: RESOLVED WONTFIX

(Toolkit :: Themes, defect)

Description

[Julien "_FrnchFrgg_" RIVAUD]

According to discussion on IRC, whereas winestripe cannot afford to be broken without native theming because of non uxtheme-able Windows, gnomestripe depends on the native theming and doesn't need to be usable without it; a lot of the CSS (borders, backgrounds) is thus unneeded yet costly, so we should clean up gnomestripe.

Comment 1

[Julien "_FrnchFrgg_" RIVAUD]

Attachment: WIP, v1

This is a work in progress patch; I'd like people knowing more of the theme structure to say if some things that I removed should be put elsewhere (for other rules that assumed that border/background would be already set).
While doing the cleanup, I noticed that about half of the css files have no border/background set for native themed widgets, and the other half (probably older definitions, or coming from winstripe) needs cleanup.

Comment 2

[Julien "_FrnchFrgg_" RIVAUD]

Attachment: Real WIP, v1

Sorry, last patch was garbage (an old ultrabitrotted patch I downloaded about another bug)

Comment 3

[Reed Loden [:reed]]

Ryan, can you take a look at this?

Comment 4

[Julien "_FrnchFrgg_" RIVAUD]

Attachment: Cleanup patch

I dogfooted this patch for a long time without noticing problems, and refrained to remove code if I was too unsure. Maybe there remains some part of the CSS that overrides a -moz-appearance and expect the previous styling to be there to base upon, thus breaking with this patch... I hope this is not the case and I have correctly verified the dependencies...

Comment 5

[Julien "_FrnchFrgg_" RIVAUD]

I conducted a small Txul test with and without the patch, and with 3 runs of standard Txul (only 10 browser windows opened one at a time, the first ignored) with, and 3 without, I found that the performance gains of this patch are pretty much in the noise range, so not that interesting.

I believe that the first window show gains more with this patch, but since there is much more noise for this one it's difficult to say for sure.

I'll try to do more comprehensive tests when I have more time, but the net result seems to be that it's not critical enough to bother checkin in something potentially dangerous this late in the game for so small an effect on performance.

This is still interesting for cleanup sake, but not for 1.9 anyway

Comment 6

[Dão Gottwald [:dao]]

Are you sure this wouldn't break stuff? Somebody could be setting -moz-appearance:none and expect a meaningful fallback styling.

Comment 7

[:Felipe Gomes (needinfo for replies!)]

Comment 5 says the wins from this bug were in the noise range, and comment 6 says it might be risk to do these changes, so Wontfix