412316 - Prevent users shooting their feet off in the preference window

Status: RESOLVED FIXED

(Other Applications :: ChatZilla, defect)

Description

[James Ross]

Particularly with logging, but also some other settings, users keep doing things in the preference window that they really shouldn't, and we need to stop them. All the /pref and co. commands will still work, but hiding the options and making some things read-only will help.

I propose hiding the following prefs:
  logFileName (full path)
  logFile.* (formatting of filenames)

This will leave just log (enabled option) and logFolder for Global Settings, and just log for all other views.

Comment 1

[James Ross]

Attachment: [checked in] Hide logging and other prefs

I've hidden a few other prefs, like "multiline" and "outputWindowURL" which are really not meant to be exposed to the user. Things like "activityFlashDelay" probably shouldn't even be prefs, generally speaking, either.

Comment 2

[:Gijs (he/him)]

Comment on attachment 297939 [details] [diff] [review]
[checked in] Hide logging and other prefs

r=gijs

Comment 3

[James Ross]

Comment on attachment 297939 [details] [diff] [review]
[checked in] Hide logging and other prefs

Checked in.

May come up with some more changes, may not.

Comment 4

[worms]

(In reply to comment #1)
> Created an attachment (id=297939) [details]
> Hide logging and other prefs
> 
> I've hidden a few other prefs, like "multiline" and "outputWindowURL" which are
> really not meant to be exposed to the user. Things like "activityFlashDelay"
> probably shouldn't even be prefs, generally speaking, either.
> 

How do I change my output window of choice now? That'd be a command line?

Comment 5

[James Ross]

Yes, all the preferences are still accessible via /pref, /network-pref, etc., we're just stopping the casual user from doing something silly. :)

Comment 6

[James Ross]

I think I'm done here. I can't see anything else that users would cause major problems with if they unknowingly edited.