412318 - Verify that all pkix functions that return SECStatus set NSPR error code

Status: NEW

(NSS :: Libraries, defect, P2)

Description

[Alexei Volkov]

In review comments to bug 408434:

3. There are many pkix_pl_ functions (like the following one) that return a 
SECStatus, but do not set any error code (e.g. don't call PORT_SetError).  
How is the caller supposed to know what went wrong if they fail?

> SECStatus
> pkix_pl_HttpDefaultClient_CreateSessionFcn(
>         const char *host,
>         PRUint16 portnum,
>         SEC_HTTP_SERVER_SESSION *pSession)
> {
>         PKIX_Error *err = pkix_pl_HttpDefaultClient_CreateSession
>                 (host, portnum, pSession, plContext);
> 
>-        if (err == NULL) {
>-                return SECSuccess;
>-        } else {
>+        if (err) {
>                 PKIX_PL_Object_DecRef((PKIX_PL_Object *)err, plContext);
>                 return SECFailure;
>         }
>+        return SECSuccess;
> }

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

The bug assignee is inactive on Bugzilla, and this bug has priority 'P2'.
:beurdouche, could you have a look please?

For more information, please visit auto_nag documentation.

Comment 2

[Marco Castelluccio [:marco]]

We have modified the bot to only consider P1 as high priority, so I'm cancelling the needinfo here.