412341 - clicking opened menuitem or combobox doesn't close menu

Status: VERIFIED FIXED

(Core :: Widget: Gtk, defect)

Description

[u294409]

User-Agent:       Mozilla/5.0 (X11; U; Linux i686; pl; rv:1.9b3pre) Gecko/2008011404 openSUSE/10.3 Minefield/3.0b3pre
Build Identifier: Mozilla/5.0 (X11; U; Linux i686; pl; rv:1.9b3pre) Gecko/2008011404 openSUSE/10.3 Minefield/3.0b3pre

menu in firefox trunk doesn't behave like native gtk menu widget.

Reproducible: Always

Steps to Reproduce:
1. open menu
2. click opened menu's menubar item ("top menu item")
Actual Results:  
menu opens again, while it's opened

Expected Results:  
menu should close itself

Comment 1

[u294409]

I noticed it doesn't work well for comboboxes too

Comment 2

[Olli Pettay [:smaug][[e-mail]]]

This is a regression.
Is this Linux only?

Comment 3

[(not currently active) Ted Mielczarek]

Appears to WFM on Win32.

Comment 4

[Olli Pettay [:smaug][[e-mail]]]

2008011304 works, 2008011404 doesn't.

Comment 5

[Olli Pettay [:smaug][[e-mail]]]

Probably bug 188126

Comment 6

[u294409]

Don't ask me about Windows/etc, because I don't use this sh**, I mean I use only Linux.

Comment 8

[Matthew Gregan [:kinetik]]

Attachment: patch

We can't set gConsumeRollupEvent to PR_FALSE in the nsWindow::CaptureRollupEvents aDoCapture == PR_FALSE path  because if check_for_rollup causes an extant rollup to roll up, CaptureRollupEvents will be called with aDoCapture == PR_FALSE, causing us to set gConsumeRollupEvent to PR_FALSE.  This means that gConsumeRollupEvent ends up always being PR_FALSE when we care about the value (i.e. after a call to check_for_rollup).

Fix regression caused by the last minute addition of the gConsumeRollupEvent = PR_FALSE to my patch in bug 188126.  That little change was actually unnecessary and an attempt to be tidy, but turned out to be plain wrong.

Comment 9

[u294409]

Same issue for favicon clicking and it's tooltip.

Comment 10

[Reed Loden [:reed]]

Checking in widget/src/gtk2/nsWindow.cpp;
/cvsroot/mozilla/widget/src/gtk2/nsWindow.cpp,v  <--  nsWindow.cpp
new revision: 1.251; previous revision: 1.250
done

Comment 11

[[:Aleksej]]

VERIFIED FIXED this and bug 412425 with
Mozilla/5.0 (X11; U; Linux i686 (x86_64); en-US; rv:1.9b3pre) Gecko/2008011604 Minefield/3.0b3pre
Mozilla/5.0 (X11; U; Linux i686 (x86_64); en-US; rv:1.9b3pre) Gecko/2008011704 Minefield/3.0b3pre
Mozilla/5.0 (X11; U; Linux i686 (x86_64); en-US; rv:1.9b3pre) Gecko/2008011804 Minefield/3.0b3pre