412455 - Regression, EV UI no longer shows up

Status: RESOLVED FIXED

(Core :: Security: PSM, defect)

Description

[Kai Engert [:KaiE:]]

As noted in bug 406755 comment 11 and 12, bug 406999 caused a regression.
The EV UI (green identity area) no longer shows up.

(This affects only people who were testing EV with the special environment variables set.)

Comment 1

[Kai Engert [:KaiE:]]

Fix in hand. Requesting blocking. I'm surprised I didn't catch this in my testing of bug 406999.

Comment 2

[Kai Engert [:KaiE:]]

The culprit was my new function hasCertErrors() added in 406999.
I added an incorrect conclusion, the new code says:
  "if !mSSLStatus->mHaveCertStatus then the cert is bad"

But I misinterpreted the meaning of variable mHaveCertStatus.
For good certs this variable always remains at false.
Only for certs which receive a "bad cert" callback from NSS this variable might change to true.

The variable should really be named mHaveCertErrorBits.
I propose to rename the variable as part of this fix to avoid future confusion.

Comment 3

[Kai Engert [:KaiE:]]

Attachment: Patch v1

Proposed fix

Comment 4

[Robert Relyea]

Comment on attachment 297187 [details] [diff] [review]
Patch v1

r+ = rrelyea

Comment 5

[Kai Engert [:KaiE:]]

Comment on attachment 297187 [details] [diff] [review]
Patch v1

requesting approval.

small change in nsNSSSocketInfo::hasCertErrors(), remainder of patch is a variable rename

Comment 6

[Kai Engert [:KaiE:]]

fixed