Clicking offline icon throws exception ["Cannot modify properties of a WrappedNative"]

VERIFIED FIXED in 0.8

Status

Calendar
Sunbird Only
VERIFIED FIXED
11 years ago
11 years ago

People

(Reporter: ssitter, Assigned: Fallen)

Tracking

unspecified
Bug Flags:
blocking-calendar0.8 +

Details

Attachments

(1 attachment, 1 obsolete attachment)

(Reporter)

Description

11 years ago
Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8.1.12pre) Gecko/2008011608 Calendar/0.8pre

Clicking the offline icon in the status bar results in an exception being thrown. Apart from that nothing happens.

Error: uncaught exception: [Exception... "Cannot modify properties of a WrappedNative"  nsresult: "0x80570034 (NS_ERROR_XPC_CANT_MODIFY_PROP_ON_WN)"  location: "JS frame :: chrome://calendar/content/calendar-offline.js :: sunbird_toggleOfflineStatus :: line 62"  data: no]

Updated

11 years ago
Flags: blocking-calendar0.8+
(Assignee)

Comment 1

11 years ago
Created attachment 297524 [details] [diff] [review]
Use nsIIOService2

We were using wrong interface. An older version of the offline patch used to automatically QI to nsIIOService2 in getIOService(). We could either fix as this patch does, or do the QI in getIOService().
Assignee: nobody → philipp
Status: NEW → ASSIGNED
Attachment #297524 - Flags: review?(daniel.boelzle)

Comment 2

11 years ago
Created attachment 297529 [details] [diff] [review]
nsIOService2

I'd prefer the use of nsIOService2 right in getIOService(); carrying forward r+ from philipp on IRC.
(I am wondering about this, because IIRC we had this in the WIP patches... as well as the io-service replacements, bug 412768... hmm)
Attachment #297524 - Attachment is obsolete: true
Attachment #297529 - Flags: review+
Attachment #297524 - Flags: review?(daniel.boelzle)

Comment 3

11 years ago
Checked in on HEAD and MOZILLA_1_8_BRANCH => FIXED
Status: ASSIGNED → RESOLVED
Last Resolved: 11 years ago
OS: Windows XP → All
Hardware: PC → All
Resolution: --- → FIXED
Target Milestone: --- → 0.8
(Reporter)

Comment 4

11 years ago
Verified using Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8.1.12pre) Gecko/2008011710 Calendar/0.8pre.
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.