412749 - "self signed" should read "self-signed"

Status: VERIFIED FIXED

Description

[Stephen Donner [:stephend]]

Build ID: Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.4; en-US; rv:1.9b3pre) Gecko/2008011604 Minefield/3.0b3pre

Summary: "self signed" should read "self-signed"

Steps to Reproduce:

1. Load a page with a self-signed cert (having a hard time finding one right now, though)

See http://lxr.mozilla.org/seamonkey/source/security/manager/locales/en-US/chrome/pipnss/pipnss.properties#342

"self signed" should read "self-signed", because it's a compound verb.

Comment 1

[Jared Givens]

Attachment: patch to fix this bug

See the patch for the fix

Comment 2

[Johnathan Nightingale [:johnath]]

(In reply to comment #1)
> Created an attachment (id=313887) [details]
> patch to fix this bug
> 
> See the patch for the fix

Thanks for the patch - can you also include the occurrence mentioned in comment 0, from security/manager/locales/en-US-/chrome/pipnss/pipnss.properties?

Comment 3

[Jared Givens]

Attachment: second part

Here is a patch to fix second occurrence.

Comment 4

[Tyler Downer [He/Him]]

Johnathan, how do these look?

Comment 5

[Tyler Downer [He/Him]]

I will create a single patch with the new trunk (3.2a1pre) code. Should be the same, but only one patch will make it easier.

Comment 6

[Tyler Downer [He/Him]]

Attachment: patch merged, v1

This simply merges the code from the first two patches. Thanks Jared for doing that.

Comment 7

[Johnathan Nightingale [:johnath]]

Comment on attachment 354248 [details] [diff] [review]
patch merged, v1

Looks good to me, but technically it should get a review from a PSM peer.

Thanks Tyler and Jared for putting this together!  We're past string freeze for Firefox 3.1, but it can land on trunk once it has Kai's okay, and will make it into the next version of Firefox.

Comment 8

[Kai Engert (:kaie:)]

Comment on attachment 354248 [details] [diff] [review]
patch merged, v1

r=kaie

Comment 9

[Kai Engert (:kaie:)]

Axel, do you need a string-id change for a text change from "self signed" to "self-signed"?

Comment 10

[Axel Hecht [:Pike]]

This seems to be a "English grammar" problem more than a "use the right technical term", even though I have found odd translations of that while going through mxr.

Guess a post to .l10n is in order, I'll do that. But no change of string-ids.

Comment 11

[Dão Gottwald [::dao]]

http://hg.mozilla.org/mozilla-central/rev/1a90cfa5b7f8

Comment 12

[Axel Hecht [:Pike]]

Posted http://groups.google.com/group/mozilla.dev.l10n/browse_frm/thread/fa21d2cf04bb85f4#, too.

Comment 13

[Mike Beltzner [:beltzner, not reading bugmail]]

Comment on attachment 354248 [details] [diff] [review]
patch merged, v1

a191=beltzner

Comment 14

[Dão Gottwald [::dao]]

http://hg.mozilla.org/releases/mozilla-1.9.1/rev/a3369f444a91

Comment 15

[Aakash Desai [:aakashd]]

Using https://www.hskupin.info/ . Verified FIXED on Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9.2a1pre) Gecko/20090413 Minefield/3.6a1pre ID:20090413031052

and

Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9.2a1pre) Gecko/20090413 Minefield/3.6a1pre ID:20090413031052

Comment 16

[Aakash Desai [:aakashd]]

ack, here's the build ID for Shiretoko Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9.1b4pre) Gecko/20090413 Shiretoko/3.5b4pre ID:20090413031313

Comment 17

[Chris Ilias [:cilias]]

user-doc-complete
<https://support.mozilla.com/kb/This+Connection+Is+Untrusted?bl=n>