Closed
Bug 412749
Opened 15 years ago
Closed 14 years ago
"self signed" should read "self-signed"
Categories
(Core :: Security: PSM, defect)
Core
Security: PSM
Tracking
()
VERIFIED
FIXED
mozilla1.9.2a1
People
(Reporter: stephend, Assigned: tdowner)
Details
(Keywords: user-doc-complete, verified1.9.1)
Attachments
(1 file, 2 obsolete files)
2.61 KB,
patch
|
KaiE
:
review+
johnath
:
ui-review+
beltzner
:
approval1.9.1+
|
Details | Diff | Splinter Review |
Build ID: Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.4; en-US; rv:1.9b3pre) Gecko/2008011604 Minefield/3.0b3pre Summary: "self signed" should read "self-signed" Steps to Reproduce: 1. Load a page with a self-signed cert (having a hard time finding one right now, though) See http://lxr.mozilla.org/seamonkey/source/security/manager/locales/en-US/chrome/pipnss/pipnss.properties#342 "self signed" should read "self-signed", because it's a compound verb.
Reporter | ||
Updated•15 years ago
|
Whiteboard: [good first bug]
Updated•15 years ago
|
Assignee: kengert → nobody
Comment 1•15 years ago
|
||
See the patch for the fix
Comment 2•15 years ago
|
||
(In reply to comment #1) > Created an attachment (id=313887) [details] > patch to fix this bug > > See the patch for the fix Thanks for the patch - can you also include the occurrence mentioned in comment 0, from security/manager/locales/en-US-/chrome/pipnss/pipnss.properties?
Comment 3•15 years ago
|
||
Here is a patch to fix second occurrence.
Assignee | ||
Comment 4•14 years ago
|
||
Johnathan, how do these look?
Assignee | ||
Comment 5•14 years ago
|
||
I will create a single patch with the new trunk (3.2a1pre) code. Should be the same, but only one patch will make it easier.
Assignee: nobody → tyler
Status: NEW → ASSIGNED
Assignee | ||
Comment 6•14 years ago
|
||
This simply merges the code from the first two patches. Thanks Jared for doing that.
Attachment #313887 -
Attachment is obsolete: true
Attachment #314776 -
Attachment is obsolete: true
Attachment #354248 -
Flags: review?(johnath)
Comment 7•14 years ago
|
||
Comment on attachment 354248 [details] [diff] [review] patch merged, v1 Looks good to me, but technically it should get a review from a PSM peer. Thanks Tyler and Jared for putting this together! We're past string freeze for Firefox 3.1, but it can land on trunk once it has Kai's okay, and will make it into the next version of Firefox.
Attachment #354248 -
Flags: ui-review+
Attachment #354248 -
Flags: review?(kaie)
Attachment #354248 -
Flags: review?(johnath)
Assignee | ||
Updated•14 years ago
|
Whiteboard: [good first bug]
Updated•14 years ago
|
Attachment #354248 -
Flags: review?(kaie) → review+
Comment 8•14 years ago
|
||
Comment on attachment 354248 [details] [diff] [review] patch merged, v1 r=kaie
Comment 9•14 years ago
|
||
Axel, do you need a string-id change for a text change from "self signed" to "self-signed"?
Updated•14 years ago
|
Keywords: checkin-needed
Comment 10•14 years ago
|
||
This seems to be a "English grammar" problem more than a "use the right technical term", even though I have found odd translations of that while going through mxr. Guess a post to .l10n is in order, I'll do that. But no change of string-ids.
Comment 11•14 years ago
|
||
http://hg.mozilla.org/mozilla-central/rev/1a90cfa5b7f8
Status: ASSIGNED → RESOLVED
Closed: 14 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → mozilla1.9.2a1
Comment 12•14 years ago
|
||
Posted http://groups.google.com/group/mozilla.dev.l10n/browse_frm/thread/fa21d2cf04bb85f4#, too.
Updated•14 years ago
|
Attachment #354248 -
Flags: approval1.9.1?
Comment 13•14 years ago
|
||
Comment on attachment 354248 [details] [diff] [review] patch merged, v1 a191=beltzner
Attachment #354248 -
Flags: approval1.9.1? → approval1.9.1+
Updated•14 years ago
|
Keywords: checkin-needed
Comment 14•14 years ago
|
||
http://hg.mozilla.org/releases/mozilla-1.9.1/rev/a3369f444a91
Keywords: checkin-needed → fixed1.9.1
Updated•14 years ago
|
Keywords: user-doc-needed
Comment 15•14 years ago
|
||
Using https://www.hskupin.info/ . Verified FIXED on Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9.2a1pre) Gecko/20090413 Minefield/3.6a1pre ID:20090413031052 and Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9.2a1pre) Gecko/20090413 Minefield/3.6a1pre ID:20090413031052
Status: RESOLVED → VERIFIED
Keywords: fixed1.9.1 → verified1.9.1
Comment 16•14 years ago
|
||
ack, here's the build ID for Shiretoko Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9.1b4pre) Gecko/20090413 Shiretoko/3.5b4pre ID:20090413031313
Comment 17•13 years ago
|
||
user-doc-complete <https://support.mozilla.com/kb/This+Connection+Is+Untrusted?bl=n>
Keywords: user-doc-needed → user-doc-complete
You need to log in
before you can comment on or make changes to this bug.
Description
•