"self signed" should read "self-signed"

VERIFIED FIXED in mozilla1.9.2a1

Status

()

defect
VERIFIED FIXED
12 years ago
10 years ago

People

(Reporter: stephend, Assigned: tdowner)

Tracking

({user-doc-complete, verified1.9.1})

Trunk
mozilla1.9.2a1
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 2 obsolete attachments)

Build ID: Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.4; en-US; rv:1.9b3pre) Gecko/2008011604 Minefield/3.0b3pre

Summary: "self signed" should read "self-signed"

Steps to Reproduce:

1. Load a page with a self-signed cert (having a hard time finding one right now, though)

See http://lxr.mozilla.org/seamonkey/source/security/manager/locales/en-US/chrome/pipnss/pipnss.properties#342

"self signed" should read "self-signed", because it's a compound verb.
Whiteboard: [good first bug]
Assignee: kengert → nobody
Posted patch patch to fix this bug (obsolete) — Splinter Review
See the patch for the fix
(In reply to comment #1)
> Created an attachment (id=313887) [details]
> patch to fix this bug
> 
> See the patch for the fix

Thanks for the patch - can you also include the occurrence mentioned in comment 0, from security/manager/locales/en-US-/chrome/pipnss/pipnss.properties?

Posted patch second part (obsolete) — Splinter Review
Here is a patch to fix second occurrence.
Johnathan, how do these look?
I will create a single patch with the new trunk (3.2a1pre) code. Should be the same, but only one patch will make it easier.
Assignee: nobody → tyler
Status: NEW → ASSIGNED
This simply merges the code from the first two patches. Thanks Jared for doing that.
Attachment #313887 - Attachment is obsolete: true
Attachment #314776 - Attachment is obsolete: true
Attachment #354248 - Flags: review?(johnath)
Comment on attachment 354248 [details] [diff] [review]
patch merged, v1

Looks good to me, but technically it should get a review from a PSM peer.

Thanks Tyler and Jared for putting this together!  We're past string freeze for Firefox 3.1, but it can land on trunk once it has Kai's okay, and will make it into the next version of Firefox.
Attachment #354248 - Flags: ui-review+
Attachment #354248 - Flags: review?(kaie)
Attachment #354248 - Flags: review?(johnath)
Whiteboard: [good first bug]
Attachment #354248 - Flags: review?(kaie) → review+
Comment on attachment 354248 [details] [diff] [review]
patch merged, v1

r=kaie
Axel, do you need a string-id change for a text change from "self signed" to "self-signed"?
Keywords: checkin-needed
This seems to be a "English grammar" problem more than a "use the right technical term", even though I have found odd translations of that while going through mxr.

Guess a post to .l10n is in order, I'll do that. But no change of string-ids.
http://hg.mozilla.org/mozilla-central/rev/1a90cfa5b7f8
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → mozilla1.9.2a1
Attachment #354248 - Flags: approval1.9.1?
Comment on attachment 354248 [details] [diff] [review]
patch merged, v1

a191=beltzner
Attachment #354248 - Flags: approval1.9.1? → approval1.9.1+
Keywords: checkin-needed
Using https://www.hskupin.info/ . Verified FIXED on Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9.2a1pre) Gecko/20090413 Minefield/3.6a1pre ID:20090413031052

and

Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9.2a1pre) Gecko/20090413 Minefield/3.6a1pre ID:20090413031052
Status: RESOLVED → VERIFIED
ack, here's the build ID for Shiretoko Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9.1b4pre) Gecko/20090413 Shiretoko/3.5b4pre ID:20090413031313
You need to log in before you can comment on or make changes to this bug.