412841 - [Regression] Invoking POST data keyword search bookmark via Enter key doesn't send POST data (returns to search page), works with Alt+Enter key (gets results page)

Status: VERIFIED FIXED

(Firefox :: Address Bar, defect, P1)

Description

[dickvl]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9b3pre) Gecko/2008011604 Minefield/3.0b3pre
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9b3pre) Gecko/2008011604 Minefield/3.0b3pre

If I invoke a keyword search that sends POST data then nothing happens after I invoke the search with the Enter key (keyword + parameter).
It does work if I use Alt + Enter.

Reproducible: Always

Steps to Reproduce:
1) Open a page with a search form that uses POST data.
I use: http://forums.mozillazine.org/search.php

2) Set some parameters.
I used:
"Search for all terms"
"Category: Mozilla Firefox"
"Search previous: 3 months"

3) Right click the "Search for Keywords" text field and choose: "Add a Keyword for this search"
Enter a Name and Keyword (mzs) and save the bookmark.

4) Invoke a keyword search with the Enter key: mzs password <Enter>


Actual Results:  
With http://hourly-archive.localgho.st/win32/20080108_1946_firefox-3.0b3pre.en-US.win32.zip I get results.
With http://hourly-archive.localgho.st/win32/20080108_2023_firefox-3.0b3pre.en-US.win32.zip I get the search page and no results.

Repeat the keyword search and press Alt+Enter: mzs password <Alt+Enter>
Both work.


Expected Results:  
It should work in both cases.


Regression range:
http://hourly-archive.localgho.st/win32/20080108_1946_firefox-3.0b3pre.en-US.win32.zip
http://hourly-archive.localgho.st/win32/20080108_2023_firefox-3.0b3pre.en-US.win32.zip

Bonsai checkin range:
http://bonsai.mozilla.org/cvsquery.cgi?module=PhoenixTinderbox&date=explicit&mindate=1199850360&maxdate=1199852579

Could be this one: https://bugzilla.mozilla.org/show_bug.cgi?id=302575 - URL bar gets confused about what URI is loaded

Comment 1

[:Gavin Sharp [email: [e-mail]]]

Attachment: patch

Bug 302575 made us call tabbrowser.loadURIWithFlags, but that method doesn't pass the postData argument to the <browser> version.

Comment 2

[:Gavin Sharp [email: [e-mail]]]

Thanks a lot for the bug report, dickvi, it was perfect in every way :)

Comment 3

[dickvl]

You're welcome Gavin Sharp :)

Comment 4

[:Gavin Sharp [email: [e-mail]]]

mozilla/browser/base/content/tabbrowser.xml 	1.259 

Comment 5

[Al Billings [:abillings - ex-MoCo]]

Verified with Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9pre) Gecko/2008050904 Minefield/3.0pre. Nice repro steps!