Closed
Bug 412857
Opened 17 years ago
Closed 17 years ago
Don't show CFBundleVersion in Sparkle update panel
Categories
(Camino Graveyard :: General, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
Camino1.6
People
(Reporter: stuart.morgan+bugzilla, Assigned: stuart.morgan+bugzilla)
Details
(Keywords: fixed1.8.1.12)
Attachments
(1 file)
|
1.38 KB,
patch
|
mark
:
superreview+
|
Details | Diff | Splinter Review |
We need to make a Sparkle option for our use for whether or not to show the CFBundleVersion when a CFBundleShortVersionString has been specified, so that we don't have the freaky-looking version string in the update panel.
Since the whole point of CFBundleShortVersionString is to hide a non-user-friendly version string, I'll aim for defaulting it to *not* showing both.
|
Assignee | |
Comment 1•17 years ago
|
||
I filed http://sparkle.andymatuschak.org/ticket/150 for having this fixed upstream. Trunk has diverged enough that a patch I make for us won't make sense to submit upstream, so I'll just change our local stuff directly and work with Andy to make sure that there's a fix to Sparkle trunk as well.
|
|
Assignee | |
Comment 2•17 years ago
|
||
Just rips out the display of the raw version.
Attachment #297799 -
Flags: superreview?(mark)
|
||
Comment 3•17 years ago
|
||
Comment on attachment 297799 [details] [diff] [review]
fix
Make a note of this change in camino/sparkle/README.
Attachment #297799 -
Flags: superreview?(mark) → superreview+
|
|
Assignee | |
Comment 4•17 years ago
|
||
Landed on trunk and MOZILLA_1_8_BRANCH with README comments.
You need to log in
before you can comment on or make changes to this bug.
Description
•