Closed
Bug 412887
Opened 18 years ago
Closed 18 years ago
Disable user commands submenu for multiple user selection
Categories
(Other Applications Graveyard :: ChatZilla, defect)
Other Applications Graveyard
ChatZilla
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: Mitch, Assigned: bugzilla-mozilla-20000923)
Details
(Whiteboard: [cz-0.9.81])
Attachments
(1 file, 1 obsolete file)
|
4.90 KB,
patch
|
Gijs
:
review+
|
Details | Diff | Splinter Review |
User-Agent: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-GB; rv:1.8.1.11) Gecko/20071127 Firefox/2.0.0.11
Build Identifier: ChatZilla 0.9.80
User commands only work on a single selected user, so they should be disabled when multiple users are selected.
Reproducible: Always
Steps to Reproduce:
1. Select multiple users.
2. Observe the user commands submenu.
Actual Results:
The user commands submenu is enabled.
Expected Results:
The user commands submenu should have been disabled.
|
Reporter | |
Comment 1•18 years ago
|
||
This patch disables the user commands submenu and hides the user label when multiple users are selected.
Attachment #297676 -
Flags: superreview?(silver)
Attachment #297676 -
Flags: review?(gijskruitbosch+bugs)
|
|
Reporter | |
Updated•18 years ago
|
Attachment #297676 -
Flags: superreview?(silver)
|
Assignee | |
Updated•18 years ago
|
Version: unspecified → Trunk
|
|
Assignee | |
Updated•18 years ago
|
Status: UNCONFIRMED → NEW
Ever confirmed: true
|
||
Comment 2•18 years ago
|
||
Comment on attachment 297676 [details] [diff] [review]
Patch v1.0
Why are you hiding the user label if you're still showing the op and user commands?
Attachment #297676 -
Flags: review?(gijskruitbosch+bugs) → review+
|
|
||
Comment 3•18 years ago
|
||
Comment on attachment 297676 [details] [diff] [review]
Patch v1.0
Oops. Holding off on r+/r- until you've explained that change.
Attachment #297676 -
Flags: review+ → review?(gijskruitbosch+bugs)
|
|
Assignee | |
Comment 4•18 years ago
|
||
Assignee: rginda → silver
Attachment #297676 -
Attachment is obsolete: true
Status: NEW → ASSIGNED
Attachment #297941 -
Flags: review?(gijskruitbosch+bugs)
Attachment #297676 -
Flags: review?(gijskruitbosch+bugs)
|
|
||
Comment 5•18 years ago
|
||
Comment on attachment 297941 [details] [diff] [review]
Show user count and disable user commands if count>1
r=gijs
Attachment #297941 -
Flags: review?(gijskruitbosch+bugs) → review+
|
|
Assignee | |
Comment 6•18 years ago
|
||
Checked in --> FIXED.
Status: ASSIGNED → RESOLVED
Closed: 18 years ago
Resolution: --- → FIXED
|
|
Assignee | |
Updated•18 years ago
|
Whiteboard: [cz-0.9.81]
|
||
Updated•1 year ago
|
Product: Other Applications → Other Applications Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•