Last Comment Bug 412906 - remove sha.c and sha.h from lib/freebl
: remove sha.c and sha.h from lib/freebl
Status: RESOLVED FIXED
:
Product: NSS
Classification: Components
Component: Libraries (show other bugs)
: 3.11.8
: All All
: P4 trivial (vote)
: 3.12
Assigned To: Julien Pierre
:
:
Mentors:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2008-01-17 22:02 PST by Julien Pierre
Modified: 2008-01-22 14:49 PST (History)
0 users
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---


Attachments
Remove dead code (7.38 KB, patch)
2008-01-17 22:03 PST, Julien Pierre
nelson: review+
Details | Diff | Splinter Review

Description Julien Pierre 2008-01-17 22:02:50 PST
If I am not mistaken, this is dead code. Let's get rid of it. The real implementation is in sha_fast.c .
Comment 1 Julien Pierre 2008-01-17 22:03:31 PST
Created attachment 297693 [details] [diff] [review]
Remove dead code
Comment 2 Nelson Bolyard (seldom reads bugmail) 2008-01-22 14:45:28 PST
Comment on attachment 297693 [details] [diff] [review]
Remove dead code

There is a reference to sha.h in freebl/manifest.mn that must also 
be removed when sha.h is removed.
Comment 3 Julien Pierre 2008-01-22 14:49:25 PST
Thanks, Nelson. I checked this in to the trunk.

Checking in manifest.mn;
/cvsroot/mozilla/security/nss/lib/freebl/manifest.mn,v  <--  manifest.mn
new revision: 1.52; previous revision: 1.51
done
Removing sha.c;
/cvsroot/mozilla/security/nss/lib/freebl/sha.c,v  <--  sha.c
new revision: delete; previous revision: 1.2
done
Removing sha.h;
/cvsroot/mozilla/security/nss/lib/freebl/sha.h,v  <--  sha.h
new revision: delete; previous revision: 1.2
done

Note You need to log in before you can comment on or make changes to this bug.