Closed
Bug 412906
Opened 17 years ago
Closed 17 years ago
remove sha.c and sha.h from lib/freebl
Categories
(NSS :: Libraries, defect, P4)
Tracking
(Not tracked)
RESOLVED
FIXED
3.12
People
(Reporter: julien.pierre, Assigned: julien.pierre)
Details
Attachments
(1 file)
|
7.38 KB,
patch
|
nelson
:
review+
|
Details | Diff | Splinter Review |
If I am not mistaken, this is dead code. Let's get rid of it. The real implementation is in sha_fast.c .
|
Assignee | |
Comment 1•17 years ago
|
||
Attachment #297693 -
Flags: review?(nelson)
|
|
Assignee | |
Updated•17 years ago
|
Priority: -- → P3
Target Milestone: --- → 3.11.9
Version: 3.11.9 → 3.11.8
|
||
Updated•17 years ago
|
Severity: normal → trivial
Priority: P3 → P4
|
|
||
Comment 2•17 years ago
|
||
Comment on attachment 297693 [details] [diff] [review]
Remove dead code
There is a reference to sha.h in freebl/manifest.mn that must also
be removed when sha.h is removed.
Attachment #297693 -
Flags: review?(nelson) → review+
|
|
Assignee | |
Comment 3•17 years ago
|
||
Thanks, Nelson. I checked this in to the trunk.
Checking in manifest.mn;
/cvsroot/mozilla/security/nss/lib/freebl/manifest.mn,v <-- manifest.mn
new revision: 1.52; previous revision: 1.51
done
Removing sha.c;
/cvsroot/mozilla/security/nss/lib/freebl/sha.c,v <-- sha.c
new revision: delete; previous revision: 1.2
done
Removing sha.h;
/cvsroot/mozilla/security/nss/lib/freebl/sha.h,v <-- sha.h
new revision: delete; previous revision: 1.2
done
Status: NEW → RESOLVED
Closed: 17 years ago
Resolution: --- → FIXED
Target Milestone: 3.11.9 → 3.12
You need to log in
before you can comment on or make changes to this bug.
Description
•