Closed Bug 412923 Opened 12 years ago Closed 12 years ago

Remove gfx/gfx-config.h.in

Categories

(Firefox Build System :: General, defect)

defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: mozilla, Assigned: mozilla)

Details

Attachments

(2 files)

Attached patch do itSplinter Review
FreeType support was removed in bug 389697 but gfx/gfx-config.h.in still contains #undef MOZ_ENABLE_FREETYPE2. As that seems to be the only use of that file and it doesn't seem to be included anyway any more, we should just remove it.

Or, David, did you have a reason for not removing it in bug 389697?
Attachment #297727 - Flags: review?(ted.mielczarek)
Nope, no reason; I just missed it.  Removing sounds great.
Attachment #297727 - Flags: review?(ted.mielczarek) → review+
Attachment #297727 - Flags: approval1.9?
Attachment #297727 - Flags: approval1.9? → approval1.9+
Oops, just when I wanted to check the patch in, I noticed that I messed it up. Obviously I used the wrong redirection when appending the local diff to the cvs diff output...

I meant to actually also remove that file from the build system, like in this patch.
Assignee: nobody → mozilla
Status: NEW → ASSIGNED
Attachment #298673 - Flags: review?(ted.mielczarek)
Attachment #298673 - Flags: review?(ted.mielczarek) → review+
Attachment #298673 - Flags: approval1.9?
Comment on attachment 298673 [details] [diff] [review]
remove from build system

a=beltzner for 1.9
Attachment #298673 - Flags: approval1.9? → approval1.9+
Both patches checked into trunk.
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.