Last Comment Bug 413010 - CERT_CompareRDN may return a false match
: CERT_CompareRDN may return a false match
Product: NSS
Classification: Components
Component: Libraries (show other bugs)
: trunk
: All All
: P1 normal (vote)
: 3.12
Assigned To: Nelson Bolyard (seldom reads bugmail)
Depends on:
  Show dependency treegraph
Reported: 2008-01-18 13:17 PST by Nelson Bolyard (seldom reads bugmail)
Modified: 2008-01-22 17:13 PST (History)
4 users (show)
See Also:
Crash Signature:
QA Whiteboard:
Iteration: ---
Points: ---

patch v1 (542 bytes, patch)
2008-01-18 13:42 PST, Nelson Bolyard (seldom reads bugmail)
julien.pierre: review+
Details | Diff | Splinter Review

Description Nelson Bolyard (seldom reads bugmail) 2008-01-18 13:17:59 PST
If CERT_CompareRDN finds an attribute type in the first RDN that is not 
also present in the second RDN, it returns SECEqual, which signifies that
the two names matched.  

This bug was introduced in rev 1.21 of secname.c, which was a fix for 
Bug 210584.  It affects only the trunk.

One-line patch forthcoming.
Comment 1 Nelson Bolyard (seldom reads bugmail) 2008-01-18 13:42:36 PST
Created attachment 297850 [details] [diff] [review]
patch v1

This should fix it.
Julien, please review.
Comment 2 Nelson Bolyard (seldom reads bugmail) 2008-01-18 14:55:40 PST
Correction:  The checkin comment was wrong.  The bug introduced in rev 1.21
was a consequence of a fix for bug 372242.
Comment 3 Nelson Bolyard (seldom reads bugmail) 2008-01-22 17:13:40 PST
Checking in lib/certdb/secname.c;
new revision: 1.23; previous revision: 1.22

Note You need to log in before you can comment on or make changes to this bug.